Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacksmith Weapoon LBODs award no gold if made with colored ingots instead of basic iron ingots #5054

Open
EleosDreams opened this issue Apr 24, 2023 · 0 comments

Comments

@EleosDreams
Copy link

When turning in Blacksmith weapon LBODs for weapons made of any ingot other than iron, it currently rewards 0 gold.

This appears to be due to the m_GoldTable defintion on lines 533-566 of this file:
https://github.com/ServUO/ServUO/blob/master/Scripts/Services/BulkOrders/Rewards/Rewards.cs

I suggest the blacksmith LBOD gold table be updated so that the weapon LBOD rewards match the blacksmith armor LBODs of the same starting gold for regular / exceptional items, maintaining consistency.

For an easy visual, you can see that these weapon LBOD gold rewards match the corresponding armor in the table here:
http://tor.bplaced.net/bods-gol.htm

This is the suggested code correction for the blacksmith m_GoldTable, lines 482-568. See the comments labeled "corrected, to add colored ingots".

    private static readonly int[][][] m_GoldTable = new int[][][]
    {
        new int[][] // 1-part (regular)
        {
            new int[] { 150, 250, 250, 400, 400, 750, 750, 1200, 1200 },
            new int[] { 225, 375, 375, 600, 600, 1125, 1125, 1800, 1800 },
            new int[] { 300, 500, 750, 800, 1050, 1500, 2250, 2400, 4000 }
        },
        new int[][] // 1-part (exceptional)
        {
            new int[] { 250, 400, 400, 750, 750, 1500, 1500, 3000, 3000 },
            new int[] { 375, 600, 600, 1125, 1125, 2250, 2250, 4500, 4500 },
            new int[] { 500, 800, 1200, 1500, 2500, 3000, 6000, 6000, 12000 }
        },
        new int[][] // Ringmail (regular)
        {
            new int[] { 3000, 5000, 5000, 7500, 7500, 10000, 10000, 15000, 15000 },
            new int[] { 4500, 7500, 7500, 11250, 11500, 15000, 15000, 22500, 22500 },
            new int[] { 6000, 10000, 15000, 15000, 20000, 20000, 30000, 30000, 50000 }
        },
        new int[][] // Ringmail (exceptional)
        {
            new int[] { 5000, 10000, 10000, 15000, 15000, 25000, 25000, 50000, 50000 },
            new int[] { 7500, 15000, 15000, 22500, 22500, 37500, 37500, 75000, 75000 },
            new int[] { 10000, 20000, 30000, 30000, 50000, 50000, 100000, 100000, 200000 }
        },
        new int[][] // Chainmail (regular)
        {
            new int[] { 4000, 7500, 7500, 10000, 10000, 15000, 15000, 25000, 25000 },
            new int[] { 6000, 11250, 11250, 15000, 15000, 22500, 22500, 37500, 37500 },
            new int[] { 8000, 15000, 20000, 20000, 30000, 30000, 50000, 50000, 100000 }
        },
        new int[][] // Chainmail (exceptional)
        {
            new int[] { 7500, 15000, 15000, 25000, 25000, 50000, 50000, 100000, 100000 },
            new int[] { 11250, 22500, 22500, 37500, 37500, 75000, 75000, 150000, 150000 },
            new int[] { 15000, 30000, 50000, 50000, 100000, 100000, 200000, 200000, 200000 }
        },
        new int[][] // Platemail (regular)
        {
            new int[] { 5000, 10000, 10000, 15000, 15000, 25000, 25000, 50000, 50000 },
            new int[] { 7500, 15000, 15000, 22500, 22500, 37500, 37500, 75000, 75000 },
            new int[] { 10000, 20000, 30000, 30000, 50000, 50000, 100000, 100000, 200000 }
        },
        new int[][] // Platemail (exceptional)
        {
            new int[] { 10000, 25000, 25000, 50000, 50000, 100000, 100000, 100000, 100000 },
            new int[] { 15000, 37500, 37500, 75000, 75000, 150000, 150000, 150000, 150000 },
            new int[] { 20000, 50000, 100000, 100000, 200000, 200000, 200000, 200000, 200000 }
        },
        new int[][] // 2-part weapons (regular) - corrected, to add colored ingots - mimic ringmail normal
        {
            new int[] { 3000, 5000, 5000, 7500, 7500, 10000, 10000, 15000, 15000 },
            new int[] { 4500, 7500, 7500, 11250, 11500, 15000, 15000, 22500, 22500 },
            new int[] { 6000, 10000, 15000, 15000, 20000, 20000, 30000, 30000, 50000 }
        },
        new int[][] // 2-part weapons (exceptional) - corrected, to add colored ingots - mimic ringmail exceptional
        {
            new int[] { 5000, 10000, 10000, 15000, 15000, 25000, 25000, 50000, 50000 },
            new int[] { 7500, 15000, 15000, 22500, 22500, 37500, 37500, 75000, 75000 },
            new int[] { 10000, 20000, 30000, 30000, 50000, 50000, 100000, 100000, 200000 }
        },
        new int[][] // 5-part weapons (regular) - corrected, to add colored ingots - mimic chainmail normal
        {
            new int[] { 4000, 7500, 7500, 10000, 10000, 15000, 15000, 25000, 25000 },
            new int[] { 6000, 11250, 11250, 15000, 15000, 22500, 22500, 37500, 37500 },
            new int[] { 8000, 15000, 20000, 20000, 30000, 30000, 50000, 50000, 100000 }
        },
        new int[][] // 5-part weapons (exceptional) - corrected, to add colored ingots - mimic chainmail exceptional
        {
            new int[] { 7500, 15000, 15000, 25000, 25000, 50000, 50000, 100000, 100000 },
            new int[] { 11250, 22500, 22500, 37500, 37500, 75000, 75000, 150000, 150000 },
            new int[] { 15000, 30000, 50000, 50000, 100000, 100000, 200000, 200000, 200000 }
        },
        new int[][] // 6-part weapons (regular) - corrected, to add colored ingots - mimic chainmail / platemail normal
        {
            new int[] { 4000, 7500, 7500, 10000, 10000, 15000, 15000, 25000, 25000 },
            new int[] { 6000, 11250, 11250, 15000, 15000, 22500, 22500, 37500, 37500 },
            new int[] { 10000, 20000, 30000, 30000, 50000, 50000, 100000, 100000, 200000 }
        },
        new int[][] // 6-part weapons (exceptional) - corrected, to add colored ingots - mimic chainmail exceptional
        {
            new int[] { 7500, 15000, 15000, 25000, 25000, 50000, 50000, 100000, 100000 },
            new int[] { 11250, 22500, 22500, 37500, 37500, 75000, 75000, 150000, 150000 },
            new int[] { 15000, 30000, 50000, 50000, 100000, 100000, 200000, 200000, 200000 }
        }
    };

Thank you for your consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant