Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mage weapons not altering skill #5034

Open
wtfuzzy opened this issue Dec 9, 2022 · 0 comments
Open

Mage weapons not altering skill #5034

wtfuzzy opened this issue Dec 9, 2022 · 0 comments

Comments

@wtfuzzy
Copy link

wtfuzzy commented Dec 9, 2022

Bringing up a new shard based on p58-wip (as of 6934d92), I found equipping a mage weapon did not alter Magery skill. Tested with Ember Staff and various magic wands.

I've tracked the problem as far as 6b73fb1, which contains, amongst others, this change:

-                m_MageMod = new DefaultSkillMod(SkillName.Magery, true, -30 + m_AosWeaponAttributes.MageWeapon);
+                m_MageMod = new EquipedSkillMod(SkillName.Magery, true, -30 + m_AosWeaponAttributes.MageWeapon, this, from);

I'm sure it's not the real fix, but reversing this specific change restored mage weapons to their proper function (as far as I can tell, anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant