-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D2DEnableRuntimeCompilation]
is ignored if [assembly: D2DShaderProfile(...)]
is used
#792
Comments
The diagnostic already exists and there is a test for this scenario as well: Lines 290 to 312 in 5eea4d0
Checking the code also seems fine. Are you using an older version maybe? Can you try with the latest nightly? |
Okay it looks like your diagnostic does fire, so I must've been on a nightly build that was before you implemented that I'd still like the ability to override this on a per-shader basis, but I did figure out my build perf problems and they weren't CS related. So this isn't a high priority item for me at all. |
As per our Discord conversation, it appears that
[assembly: D2DShaderProfile(...)]
takes precedence over (non-assembly-wide)[D2DEnableRuntimeCompilation]
.Either I should be able to use
[D2DEnableRuntimeCompilation]
on specific shaders in order to disable compile-time compilation ...... or it should emit a compile-time error/diagnostic
I do want to be able to use the attribute in this way so I can diagnose some build performance issues.
The text was updated successfully, but these errors were encountered: