Download the artifacts for this pull request:

• ryujinx-Release-1.1.0+f840145-linux_arm64
• ryujinx-Release-1.1.0+f840145-macos_universal
• ryujinx-Release-1.1.0+f840145-linux_x64
• ryujinx-Release-1.1.0+f840145-win_x64

Issues

No Known issues

Features that work as intended:tm:

Updates can be applied to multi-xci games/can be enabled or disabled

Updates and dlc can be applied to non multi-xci games

No duplicate entries in gtk for updates

Loaded ROBOTICS_NOTES DaSH v0 (010039A0117C0000) + ROBOTICS_NOTES ELITE v0 (01002A900EE8A000).xci
ELITE is the main game and DaSH is the spin-off. In 1.1.1239 only DaSH shows up in game list and loads from file menu.

In 1.1.0+b1bc5b9, both games do show up on my game list, and both load from the list.

However, when loading from the file menu, ELITE loads but with Loading Unknown and a generic icon. Though, the game does start.

I do not belive this game has any DLC or updates.

Thank you @piplup55 and @erictbar I think I addressed all the issues with my latest push. Builds will be ready in about 20 minutes if you want to test again!

Thank you @piplup55 and @erictbar I think I addressed all the issues with my latest push. Builds will be ready in about 20 minutes if you want to test again!

Icon & title fixed when loading from File menu, both games still load from game list.

XCI files with multiple games are loading fine.

However it seems there is an issue when the game is bundled with multiple DLCs.
Loaded NAMCOT COLLECTION [010039F010E14000][v0].xci, the game is bundled with 10 DLCs but only one is loaded. If right click the game > Manage DLC in the GUI, it shows only 1 DLC.

The regular Ryujinx loads fine all 10 DLCs, but the emulator crashes when right click> Manage DLC.

Thank you, it should hopefully detect all of them now!

Everything seems to be working just fine for me! I only have one game to test this with though, and that's Pikmin 1+2. It's working fine. Both games load and play, and their updates apply as well.

Though, I'm having sound issues with 1, and 2's title screen doesn't show up. I cannot tell if this is a bug with this feature or bugs with the games themselves, as these are the only copies of the game I have to test.

Hoping for the reviews and merge soon :)

Can it parse complex XCI files similar to Yuzu, including game updates, DLC, MODs, and cheats within the XCI file? It seems the official release doesn't support this yet. Is there a compiled win64 version .exe file included in this PR? I'd like to test whether it can handle complex XCI files.

With the latest commit it should be possible to create specific game shortcuts as well.

Shortcuts are working fine now, Thank you!

I tested a few more games (over 40 games) including multi-games.xci, single-game.xci and game.nsp and they all loaded fine, except 4 of them. These four games are single-game.xci:

• MONSTER HUNTER STORIES 2: WINGS OF RUIN v1.0.1 [0100E21011446000]
• Puyo Puyo™ Tetris® v1.0.0 [010073C001D5E000]
• Puyo Puyo™ Tetris® 2 v1.0.0 [010038E011940000]
• Splatoon 2 v1.0.0 [01003BC0000A0000]

All of these games load normally in the latest official version of Ryujinx.

I also noticed that with this PR the title-IDs of these four games are detected incorrectly:

I don't know if this issue occurs with any other untested game.

Error log: Ryujinx_1.1.0+c1ce433_2024-04-21_21-20-05.log

@frafes I hope this is fixed with my latest commit.

The solution for this is not as pretty as I hoped, but it should work and shouldn't cause any problems.
It's just something that will need more refactoring in the future I guess.

I hope this is fixed with my latest commit.

Thank you! All those games are loading fine.

While testing some more games I found a new issue:

When adding a game directory path to Ryujinx, the first game listed in that folder (in alphabetical order) cannot be launched either via command line or shortcut.

1. If there is only one game/file in that folder: it fails to launch via command line or shortcut.

2. If there are multiple games/files in that folder: all games can be launched, with the exception of the first one (listed in alphabetical order), when using the command line or shortcut.

However, if I remove the game directory path from Ryujinx (either in the GUI or by editing the PRConfig.json file), all games launch successfully via the command line or shortcut.

Tested both GTK and Avalonia versions, this issue occurs just with the Avalonia version. The latest official Ryujinx Avalonia version doesn't have this issue.

Log file: Ryujinx_1.1.0+6eb3a42_2024-04-30_00-08-27.log

When adding a game directory path to Ryujinx, the first game listed in that folder (in alphabetical order) cannot be launched either via command line or shortcut.

the log file you provided says it's being used by another process

If there is only one game/file in that folder: it fails to launch via command line or shortcut.

Do you get an exception and a stacktrace? If so could you post it?

Do you get an exception and a stacktrace? If so could you post it?

No, I don’t get an exception and a stacktrace, sorry. Is there a way I can get it?

Odd, are you able to reproduce this on the command line, so you get to see everything?

Odd, are you able to reproduce this on the command line, so you get to see everything?

It is basically the same that log file.

Tested in two different Windows 11 PCs, same result.

Seems like you are running multiple instances at once, or something else is accessing the files.

Doesn't look like an issue I could address here.

Doesn't look like an issue I could address here.

No problem. Thank you so much for all your hard work!

P.S.: I don't know if it's related, but when I try to sort the game list by "name" in the GUI, Ryujinx crashes. All other sort options work fine.

Log file: Ryujinx_1.1.0+6eb3a42_2024-05-02_15-34-20.log

Does that happen on master as well?

Does that happen on master as well?

It doesn't happen on master.

Looks like I'll need to investigate then, thank you!

Finally, it should be fixed now!

Anything else that came up during testing? :D

Finally, it should be fixed now!

Thank you :)

About that issue, it also happens on Linux. It's odd because that issue doesn't happen on master.

Log file: Ryujinx_1.1.0+38c2cf8_2024-05-03_21-55-31.log

As the exception says, the file is used by another process. Make sure there is nothing else accessing the file and try again.
Most of the time this happens, people open Ryujinx twice.

Unfortunately I couldn't find what is causing this. Anyway, if I find something new, I'll let you know. Thank you!

Let's do that in a separate PR, since this one is already large enough and I would need to change more strings than currently affected by this PR.