Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job results should be cached once job.result() is called #1691

Closed
nonhermitian opened this issue May 17, 2024 · 2 comments
Closed

Job results should be cached once job.result() is called #1691

nonhermitian opened this issue May 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@nonhermitian
Copy link
Contributor

What is the expected feature or enhancement?

Getting job results has to query the API each time job.result() is called. This makes code very slow, and should not have to be done more than once. Results used to be cached, and should be again.

Acceptance criteria
Job results are cached

@nonhermitian nonhermitian added the enhancement New feature or request label May 17, 2024
@kt474
Copy link
Member

kt474 commented May 17, 2024

Caching job results was removed ~6 months ago - the logic behind the decision was that job results can be very large and the user does not have an easy way to free up the memory (discussed in ch-performance)

@jyu00
Copy link
Collaborator

jyu00 commented May 20, 2024

Like @kt474 said, we removed the caching because people were complaining about memory consumption after running many jobs. And one can easily cache results locally by assigning them to a local variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants