Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime should verify that Qiskit register names are compatible with the service #1686

Open
nonhermitian opened this issue May 16, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@nonhermitian
Copy link
Contributor

What is the expected feature or enhancement?
Qiskit allows one to name registers pretty much anything because they are strings. However, the results of runtime are returned via attributes that do not accept all things a string does, e.g. not '0', ''?'`, etc. It would be nice to validate that register names are compatible with the Runtime service.

Acceptance criteria

@nonhermitian nonhermitian added the enhancement New feature or request label May 16, 2024
@ihincks
Copy link
Collaborator

ihincks commented May 17, 2024

As a technical note to whoever picks this up, I imagine we want isidentifier to be true, and probably also iskeyword to be false, because the DataBin class allows access via attribute name.

@ihincks
Copy link
Collaborator

ihincks commented May 23, 2024

I expect this fix should be made in qiskit, and ported here until 1.2. It's more a bug then an enhancement: coercion needs to fail for bad register names, because it will inevitably lead to invalid DataBins otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants