Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If experiment_data.save() fails it should raise an exception #1134

Open
oliverdial opened this issue Apr 11, 2023 · 4 comments · May be fixed by #1278
Open

If experiment_data.save() fails it should raise an exception #1134

oliverdial opened this issue Apr 11, 2023 · 4 comments · May be fixed by #1278

Comments

@oliverdial
Copy link

https://github.com/Qiskit/qiskit-experiments/blob/049436a3d184adb51bb559316483cd44f1e2c925/qiskit_experiments/framework/experiment_data.py#L1339

Here; if you hit this condition the experiment data is not saved, but the function returns as if it had saved. In the context of, for example launching a bunch of experiments from a loop, this could cause a user to lose a lot of data. (or am I missing something here?)
@coruscating
Copy link
Collaborator

Users don't typically call expdata.save() and then immediately overwrite expdata with the experiment data returned from the next experiment, which is why this hasn't been surfaced as an issue so far, but I do think the handling can be improved here. Since suppress_errors is already a flag, I'm not sure why it doesn't apply to this conditional as well. @gadial what do you think?

@oliverdial
Copy link
Author

oliverdial commented Apr 11, 2023 •
edited

(If you want another use case, run_qe will return with an exit code that indicates success, even if save() fails.)

@gadial
Copy link
Contributor

gadial commented Apr 17, 2023

I agree; no reason not to raise an error here if we already have the (new) suppress_errors flag.

@coruscating coruscating linked a pull request Sep 27, 2023 that will close this issue
Open
@coruscating
Copy link
Collaborator

I put in a fix for this in #1278. Note that if you were calling save(), which is what most users do, it already raises an error when there's no service:

qiskit-experiments/qiskit_experiments/framework/experiment_data.py

Lines 1696 to 1705 in f33bed7

if not self._service:
LOG.warning(
"Experiment cannot be saved because no experiment service is available. "
"An experiment service is available, for example, "
"when using an IBM Quantum backend."
)
if suppress_errors:
return
else:
raise ExperimentDataSaveFailed("No service found")

So the new fix is only for the case when someone calls save_metadata() separately to save only the metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise error when saving metadata without a service coruscating/qiskit-experiments
3 participants
@gadial @oliverdial @coruscating