Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SourceGenerator with IIncrementalGenerator #21228

Open
5 tasks done
adityapatwardhan opened this issue Feb 14, 2024 · 0 comments · May be fixed by #23815
Open
5 tasks done

Replace SourceGenerator with IIncrementalGenerator #21228

adityapatwardhan opened this issue Feb 14, 2024 · 0 comments · May be fixed by #23815
Labels
In-PR Indicates that a PR is out for the issue Needs-Triage The issue is new and needs to be triaged by a work group.

Comments

@adityapatwardhan
Copy link
Member

Prerequisites

Steps to reproduce

RS1035 warning is disabled in PSVersionSourceGenerator.cs. It uses SourceGenerator. It is deprecated and needs to be replaced with IIncrementalGenerator

More info: https://github.com/dotnet/roslyn/blob/main/docs/features/incremental-generators.md

Expected behavior

IIncrementalGenerator needs to be implemented

Actual behavior

Remove SourceGenerator

Error details

No response

Environment data

Latest source

Visuals

No response
@adityapatwardhan adityapatwardhan added the Needs-Triage The issue is new and needs to be triaged by a work group. label Feb 14, 2024
@adityapatwardhan adityapatwardhan mentioned this issue Feb 14, 2024
Merged
22 tasks
@iSazonov iSazonov linked a pull request May 17, 2024 that will close this issue
Open
22 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR Indicates that a PR is out for the issue labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In-PR Indicates that a PR is out for the issue Needs-Triage The issue is new and needs to be triaged by a work group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace PSVersion source generator with incremental one iSazonov/PowerShell
1 participant
@adityapatwardhan