Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building interiors constructed by a farmhand not tracked correctly for events until world is restarted #710

Open
Pathoschild opened this issue May 3, 2020 · 0 comments
Labels
bug This is an unintended error or behavior that can be addressed with specific development changes. external This ticket is about an issue with (or changes for) something outside SMAPI itself.

Comments

@Pathoschild
Copy link
Owner

When a farmhand constructs a new farm building, multiplayer sync on other players continuously replaces the Building::indoors value for farm buildings with a new location instance.

That breaks events since SMAPI ends up watching an old location instance that doesn't have the new changes, and SMAPI can't just rebuild the location tracker (since that would lose any changes done as part of the sync).

Repro steps

  1. Install Automate and CJB Cheats Menu.
  2. Enable verbose mode in smapi-internal/config.json.
  3. Launch the game twice: once to host a multiplayer server, and once to join it as a farmhand.
  4. As the farmhand, construct a new shed with CJB Cheats Menu's instant build enable.
    The host console should show a verbose Automate log about a new location.
  5. As the host, enter the shed and put down some chests/machines/inputs for Automate.
    The host console doesn't show any Automate logs about object changes, and automation doesn't work in the shed.
@Pathoschild Pathoschild added the bug This is an unintended error or behavior that can be addressed with specific development changes. label May 3, 2020
@Pathoschild Pathoschild changed the title Building interiors not tracked for events correctly in multiplayer Building interiors constructed by a farmhand not tracked correctly for events until world is restarted Dec 31, 2020
@Pathoschild Pathoschild added the external This ticket is about an issue with (or changes for) something outside SMAPI itself. label May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is an unintended error or behavior that can be addressed with specific development changes. external This ticket is about an issue with (or changes for) something outside SMAPI itself.
Projects
None yet
Development

No branches or pull requests

1 participant