Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQ] [java] create a builder pattern for the models #18032

Closed
jpfinne opened this issue Mar 5, 2024 · 0 comments · Fixed by #18650
Closed

[REQ] [java] create a builder pattern for the models #18032

jpfinne opened this issue Mar 5, 2024 · 0 comments · Fixed by #18650
Labels
Enhancement: Feature

Comments

@jpfinne
Copy link
Contributor

jpfinne commented Mar 5, 2024

Is your feature request related to a problem? Please describe.

A good builder pattern generation can solve many issues:

  • initialize readonly values in the java generator
  • make it similar to the lombok builder that people are used to.
  • introduce immutability

Lombok can be used the generate builders. But the introduction of lombok creates more issues (#17793)

Describe the solution you'd like

Add a builder inner class
Add a static builder() method
Add a toBuilder() method

Describe alternatives you've considered

Reuse the builder from javaJAXRSServerCodeGen.
Fix the lombok generation issues.
@jpfinne jpfinne mentioned this issue Mar 5, 2024
Closed
5 tasks
@gdupontf gdupontf mentioned this issue Mar 21, 2024
Open
@jpfinne jpfinne mentioned this issue May 4, 2024
Closed
5 tasks
@jpfinne jpfinne mentioned this issue May 12, 2024
Closed
5 tasks
@wing328 wing328 mentioned this issue May 13, 2024
Merged
5 tasks
wing328 added a commit that referenced this issue May 14, 2024
@wing328 @jpfinne
[java] implement #18032 add builder pattern to java client and spring…
51ef868 
… generator (#18650)

* add builder pattern to java client and spring generator

* regenerate samples

* update doc

---------

Co-authored-by: jpfinne <jeanpaul@finne.be>
renatomameli pushed a commit to renatomameli/openapi-generator that referenced this issue May 17, 2024
@wing328 @jpfinne
[java] implement OpenAPITools#18032 add builder pattern to java clien…
7f6226a 
…t and spring generator (OpenAPITools#18650)

* add builder pattern to java client and spring generator

* regenerate samples

* update doc

---------

Co-authored-by: jpfinne <jeanpaul@finne.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement: Feature
Projects
None yet
Milestone
No milestone
1 participant
@jpfinne