Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check-targets doesn't have all dependencies in the CMakeLists.txt files #1571

Open
4 tasks done
schweitzpgi opened this issue Apr 25, 2024 · 0 comments
Open
4 tasks done
Labels
bug Something isn't working build The issue related to the CUDA Quantum build good first issue Good for newcomers

Comments

@schweitzpgi
Copy link
Collaborator

Required prerequisites

  • Consult the security policy. If reporting a security vulnerability, do not report the bug using this form. Use the process described in the policy to report the issue.
  • Make sure you've read the documentation. Your issue may be addressed there.
  • Search the issue tracker to verify that this hasn't already been reported. +1 or comment there if it has.
  • If possible, make a PR with a failing test to give us a starting point to work on!

Describe the bug

When switching between different branches, the command

% make check-targets

does not build all of the runtime libraries and as a result a large number of tests will fail. One possible failure mode is a spew of undefined symbols, where the symbols are defined in the last branch that was built.

Steps to reproduce the bug

% git checkout experimental/stateHandling
% cd build; make install
% cd ..; git checkout main
% cd build; make check-targets

Expected behavior

The above sequence of commands should not produce linker failures with undefined symbols. The runtime libraries should be rebuilt.

Is this a regression? If it is, put the last known working version (or commit) here.

Not a regression

Environment

  • CUDA Quantum version: tip
  • Python version: irrelevant
  • C++ compiler: clang++ 16
  • Operating system: Ubuntu 22.04

Suggestions

No response

@schweitzpgi schweitzpgi added good first issue Good for newcomers bug Something isn't working build The issue related to the CUDA Quantum build labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build The issue related to the CUDA Quantum build good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant