Getdata<T> allocates an extra array of T[]

[circle601]

Prerequisites

• I have verified this issue is present in the develop branch
• I have searched open and closed issues to ensure it has not already been reported.

MonoGame Version

3.8.1

Which MonoGame platform are you using?

MonoGame Cross-Platform Desktop Application (mgdesktopgl)

Operating System

Windows

Description

Getdata allocates an extra array of T[] GC runs reducing the frame rate

Steps to Reproduce

            texture.GetData<Color>(0, r, TextureCheckbuffer, 0, 1);

Minimal Example Repo

No response

Expected Behavior

No extra allocations needed

Resulting Behavior

Color[] is allocated each frame

Files

No response

[mrhelmut]

This line:

https://github.com/MonoGame/MonoGame/blob/4a3d5e747ff570fbcd27ba7197d0eeac2606f906/MonoGame.Framework/Platform/Graphics/Texture2D.OpenGL.cs#L254C17-L254C86

and this line:

MonoGame/MonoGame.Framework/Platform/Graphics/Texture2D.OpenGL.cs

Line 271 in 4a3d5e7

var temp = new T[Math.Max(this.height >> level, 1) * tFullWidth];

can't be optimized with traditional stackalloc or Span because of the generic type. It could be possible by working with a byte[] and converting elements in and out from T. Or having static class-wide caching array that grows when required (still garbage-prone, but much less).

This being said, polling GetData every frame isn't a good practice and it is recommended to rework your logic to avoid relaying on GetData this much.

[SimonDarksideJ]

Does the answer suit your needs @circle601 and can this be closed now? Due to generics, this is not something solvable at this time.