Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating to StackExchange.Redis 2.1 #309

Open
erizzo opened this issue Apr 3, 2020 · 7 comments · May be fixed by #340
Open

Consider updating to StackExchange.Redis 2.1 #309

erizzo opened this issue Apr 3, 2020 · 7 comments · May be fixed by #340
Milestone

Comments

@erizzo
Copy link

erizzo commented Apr 3, 2020

StackExchange.Redis is now at version 2.1.x, and there are useful fixes in there. Most notably to me is fixing some intermittent connectivity problems with Azure Redis. That is an issue that my team has been seeing over the past year or so and caused me some sleepless nights (I work on a very large platform for a very large enterprise client, heavily invested in Azure).
Will you consider releasing an updated version of CacheManager.StackExchange.Redis? If I was willing to submit a PR would that change your answer?

@MichaCo
Copy link
Owner

MichaCo commented Apr 4, 2020

Is there any breaking change in the 2.1 client which prevents you from using that version together with CacheManager?

@erizzo
Copy link
Author

erizzo commented Apr 5, 2020

Do you mean referencing the StackExchange.Redis Nuget package directly, essentially overriding the reference in CacheManager?
We thought about that but aren't sure it will actually work. Assuming StackExchange follows semantic versioning, it's just a minor update so should be backwards-compatible.

@MichaCo
Copy link
Owner

MichaCo commented Apr 5, 2020

Yeah exactly. That's usually how you do that with Nugets, same as with .NET frameworks, I usually target slightly lower versions in libraries so that I don't force consumers to upgrade.

And, over time, dependencies might get new versions and I don't want/have to release a new version of a library just because one dependency got a new minor version.

Just give it a try.

@keithl8041
Copy link

keithl8041 commented Apr 6, 2020

Can confirm that we're running CacheManager 1.2 with SE.Redis 2.1 in production and haven't seen any issues yet.
PS - @erizzo sounds like we've been having similar Azure Redis issues.. intermittent Redis connection loss to a single Azure App Service instance only? Impossible to replicate in dev?

@erizzo
Copy link
Author

erizzo commented Apr 7, 2020

@keithl8041 Sounds similar to our issues, yes. Although we see it across a bunch of different application services (web APIs) and I'm not sure of the deployment structure, whether the affected APIs at any time are in the same app service instance or not. I'll ask our devops folks about that the next time it's reported/observed.

@tonyqus
Copy link

tonyqus commented Oct 23, 2020

We are encountering an existing a bug in StackExchange.Redis on production
StackExchange/StackExchange.Redis#1120

We use the version 2.0.0-beta-1629 with StackExchange.Redis 2.0.513

If you can create a new release based on StackExchange.Redis 2.1 version, it would work for us.

@borgmatthew
Copy link

Updated the version of StackExchange.Redis in #337

@MichaCo MichaCo linked a pull request May 31, 2021 that will close this issue
5 tasks
@MichaCo MichaCo added this to the 2.0.0 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants