Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0+] Control Panel (CabinetWClass) makes the text unreable in HDR (DwmExtendFrameIntoClientArea) #117

Open
MuscularPuky opened this issue Feb 28, 2024 · 8 comments

Comments

@MuscularPuky
Copy link

image
SDR

image
HDR

Because of pretty old & low-level bug of DWM, DwmExtendFrameIntoClientArea method makes text on acrylic/mica surface unreadable in HDR display. This is very sad thing for me a glassmorphismphile. but AccentBlurBehind method does not break HDR text. i.e.: in HDR, MicaForEveryone breaks explorer completely, but ExplorerBlurMica 1.0.7 does not break any text.

but in 2.0.1, ExplorerBlurMica started to break text on Control Panel (CabinetWClass) in HDR. Finally I did should override DwmExtendFrameIntoClientArea function of CabinetWClass to disable acrylic/blur effect. That's too bad for me a glassmorphismphile :( However, good news is ExplorerBlurMica doesn't mess general explorer window text in HDR.

Is there cpp source? Maybe I have to code a hybrid of 1.0.7 - 2.0.1, for my glassmorphismphilia. all window surcafe and ui element are to be tranparent, seethrough, and crystal-clear. Yes. That's truth.

@MuscularPuky MuscularPuky changed the title [2.0+] Control Panel (CabinetWClass) make the text unreable in HDR (DwmExtendFrameIntoClientArea) [2.0+] Control Panel (CabinetWClass) makes the text unreable in HDR (DwmExtendFrameIntoClientArea) Feb 28, 2024
@Maplespe
Copy link
Owner

If you think it's the blur method, you can try DWMBlurGlass which uses a custom blur method and the optional AccentBlur method. You can use its blur method to override Mica.

Also, DwmExtendFrameIntoClientArea is required, without it you can't extend the effect to the whole window. In 1.0.7 , the control panel did not have an Alpha rendering fix, which caused you to have to be in Dark mode to see the text.

2.0 fixes the alpha channel for text, but may cause some problems due to the control panel's old controls, we are also considering adding an option to ignore the control panel in the next version.

The latest source code is not available because it has been found that this program has been sold and adapted for integration into commercial software that is not open source and violates open source protocols.

@MuscularPuky
Copy link
Author

ah I don't used light mode recntly. that was the problem...

Unfortunetely, DWMBlurGlass the new util you just told does not work on this build. First try occurs BSOD with terrible sound, and second try does nothing. If it works would be cool stuff for me a glassblahblahphile. :(

@TechySC23
Copy link

TechySC23 commented Feb 28, 2024

Guys......... ExplorerBlurMica did something to the Control Panel...........:
image
This is Control Panel normally
image

This is after a bit roaming. Looks like a ghost version. All effects of EBM v2.0.1 are applied on it instantly after you go back and forth or just move around control panel

@TechySC23
Copy link

TechySC23 commented Feb 28, 2024

Nothing is readable and this is mica alt not pitch black. Also I have a potential answer... This might be because Control panel is a explorer windows or.... a shell skin (extension to be precise) on Explorer. Hence EBM tries to copy paste the same effect on Control Panel.

@TechySC23
Copy link

TechySC23 commented Feb 28, 2024

Nothing is readable and this is mica alt not pitch black. Also I have a potential answer... This might be because Control panel is a explorer windows or.... a shell skin (extension to be precise) on Explorer. Hence EBM tries to copy paste the same effect on Control Panel.

*the links might be but the text aren't readable. Also settings:
[config] effect=4 clearAddress=true clearBarBg=true clearWinUIBg=true showline=false [light] r=255 g=255 b=255 a=200 [dark] r=7 g=100 b=235 a=175 I have an Idea... what if you guys just find out the control panel affecting code and give it to Microsoft. They will just roll out the dark mode for control panel and solve the problem all together! (seriously not joking!🤣)

@MuscularPuky
Copy link
Author

Yes we already know. Control Panel uses Win10 explorer.

and MS will not fix control panel anymore, unless get rid of... :(

If you want to avoid hooking only for control panel, override CabinetWClass hook to other. I refered ExplorerBlurMica 1.0.7 code.

image

@TechySC23
Copy link

How did MicaForEveryone devs implemented DWMExtendFrameintoClientArea option. They literally gave an option to turn on and off!

@Maplespe
Copy link
Owner

Maplespe commented Mar 1, 2024

How did MicaForEveryone devs implemented DWMExtendFrameintoClientArea option. They literally gave an option to turn on and off!

The fact of the matter is that one must rely on DWMExtendFrameintoClientArea to extend the blur effect to the entire file explorer.
Without it, only the title bar has the effect. So please tell me, what else is the difference between this and the system default?
By the way, the control panel is part of Explorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants