Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheel not working #214

Open
OmegaRogue opened this issue Mar 16, 2023 · 1 comment · May be fixed by #215
Open

Wheel not working #214

OmegaRogue opened this issue Mar 16, 2023 · 1 comment · May be fixed by #215

Comments

@OmegaRogue
Copy link

I'm on Xorg in awesomewm v4.3-1360-gc539e0e43 on Arch Linux with the kernel version 6.2.2-arch1-1 with weylus 0.11.4.
When i start weylus and connect from a device and scroll, WheelEvents are being sent and received correctly, but Weylus isnt translating them into input events,.
When running xev and scrolling vertically with the touchpad on the weylus client, there are no xinput scroll events generated and libinput debug-events reports horizontal scroll events happening.
When scrolling horizontally on the touchpad, xev reports scroll events, libinput debug-events reports vertical scroll events.

So it seem like somewhere between receiving the Websocket messages and actually emulating the inputs on the server system, the scroll direction gets switched up and dy turns into dx and dx into dy
@OmegaRogue
Copy link
Author

Weylus/src/input/uinput_device.rs

Lines 255 to 268 in 6411ba4

self.send(
self.mouse_fd,
ET_RELATIVE,
EC_REL_WHEEL,
direction(event.dy),
);
self.send(
self.mouse_fd,
ET_RELATIVE,
EC_REL_HWHEEL,
direction(event.dy),
);
self.send(self.mouse_fd, ET_RELATIVE, EC_REL_WHEEL_HI_RES, event.dx);
self.send(self.mouse_fd, ET_RELATIVE, EC_REL_HWHEEL_HI_RES, event.dx);

looking into the code, it seems like this is where the error is happening.
Seems like an easy fix, though I'm barely familiar with Rust, but ill fix it and make a pull request

OmegaRogue added a commit to OmegaRogue/Weylus that referenced this issue Mar 16, 2023
@OmegaRogue
fix scroll direction problems in uinput
9bf2571 
closes H-M-H#214
@OmegaRogue OmegaRogue linked a pull request Mar 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix scroll direction problems in uinput OmegaRogue/Weylus
1 participant
@OmegaRogue