Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper information to table, add more information #17

Open
PrzemyslawKlys opened this issue Nov 1, 2018 · 2 comments
Open

Add proper information to table, add more information #17

PrzemyslawKlys opened this issue Nov 1, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@PrzemyslawKlys
Copy link
Member

image

It should be visible what went wrong, what went good. RIght now it's only this table and another Warning when date ranges is too wide for the event logs.

@snd3r
Copy link
Contributor

snd3r commented Nov 19, 2018

Should we add this column in other tables?
default

@PrzemyslawKlys
Copy link
Member Author

The main problem is knowing whether we have that information to include or not. I believe we need to modify PSEventViewer which by itself needs a rewrite (to include different methods of getting information) to output more information what it actually managed to scan, what failed and so on. It's quite silent on what it does, what logs did return events, what logs failed for some reason etc.

The table you're showing is actually filled out by second call direct to event logs, not thru PSEventViewer. It's possible this calls goes thru, yet PSEventViewer calls won't. This table you're showing is only verification of what logs actually store at the moment. And I don't think it even checks all logs. Probably it should be expanded (or different Table should be built) with information from all logs that are about to be scanned for events, including files, forwarders and so on.

I would say this issue is a low priority if anything.

@PrzemyslawKlys PrzemyslawKlys added the enhancement New feature or request label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants