Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From Discord: Configuring BunHttpServer for HTTPS #2720

Open
effect-bot opened this issue May 9, 2024 · 0 comments
Open

From Discord: Configuring BunHttpServer for HTTPS #2720

effect-bot opened this issue May 9, 2024 · 0 comments

Comments

@effect-bot
Copy link

Summary

The discussion revolves around configuring BunHttpServer for HTTPS. It is indeed possible to configure BunHttpServer to use HTTPS by passing tls options to the layer constructor. However, there's a noted issue with the type definitions where ServeOptions are mistakenly used instead of Serve<WebSocketDataType>. The corrected type, as provided, includes various options for serving over TLS, including TLSServeOptions and TLSWebSocketServeOptions, among others, to accommodate different configurations such as Unix sockets and WebSocket data types.

Key takeaways include:

  • BunHttpServer supports HTTPS configuration through tls options.
  • There's a type definition issue in the library that may affect implementation.
  • The corrected type definition expands the options to include TLS and WebSocket configurations, providing a comprehensive approach for HTTPS setup.

Discord thread

https://discord.com/channels/795981131316985866/1238180224529731654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant