Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filament custom fields available on spools #334

Open
cnf opened this issue Mar 17, 2024 · 2 comments
Open

Filament custom fields available on spools #334

cnf opened this issue Mar 17, 2024 · 2 comments
Labels
Feature Request New feature or request

Comments

@cnf
Copy link

cnf commented Mar 17, 2024

Is your feature request related to a problem? Please describe.
I have fields such as "RAL" and "glitter" on filaments, but those also are applicable on the spools of said filament, of course.

Describe the solution you'd like
Have the Filament custom fields available / viewable / filterable on the spools view

Describe alternatives you've considered
I don't know? I think filament information is relevant on a spool as well?

Additional context
None.

Thanks!

@cnf cnf added the Feature Request New feature or request label Mar 17, 2024
@FBrand
Copy link

FBrand commented Mar 25, 2024

Second that.
It would be useful to be able to promote Custom Fields from Vendor to Filament and from Filament to Spool.
It would probably also be useful to add a checkbox in the creation dialogue to to enable/disable the created field being promoted.

@spyder007
Copy link
Contributor

are you looking for these to be read-only fields or actual fields on the spool?

Generally, as I have been digging into the code, the filament object is properties of the filament itself, while the spool has some of it's own properties (weight, empty weight, etc). I just proposed a change to allow the empty spool weight (tare weight) to "fall" from a field on vendor to filament to spool, but really, filament shouldn't know (or care) about spool weight of any kind. I left it there to not break anyone's current implementation.

What it seems you are asking for isn't so much adding new properties to the spool, but just allowing the filament's properties to be "searchable" from the spool endpoint. If that's what you are asking for, I would agree, that makes some sense, but I might implement it as a new endpoint to avoid performance issues with the current endpoints.

If you are asking for these properties to exist and become defaults from vendor to filament to spool, well, that's a LOT of data duplication and mostly unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants