Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG in computeGaussianPerplexity when K > N - 1 #54

Open
asanakoy opened this issue Aug 21, 2018 · 1 comment
Open

BUG in computeGaussianPerplexity when K > N - 1 #54

asanakoy opened this issue Aug 21, 2018 · 1 comment

Comments

@asanakoy
Copy link

In line tsne.cpp#L37 vectors indices and distances will have < K + 1 elements if K > N - 1.
This will cause erroneous reads out of the bounds of the vector in tsne.cpp#L388 and other loops.

There should be a check that K <= N -1.
@DmitryUlyanov
Copy link
Owner

Hi Artsiom, thanks for reporting. Can you please submit a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asanakoy @DmitryUlyanov