Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetValue to null causes NullPointerException #162

Open
Haytam95 opened this issue Jul 1, 2022 · 0 comments
Open

SetValue to null causes NullPointerException #162

Haytam95 opened this issue Jul 1, 2022 · 0 comments

Comments

@Haytam95
Copy link

Haytam95 commented Jul 1, 2022

Hi, if I try to cleanup a Variable by setting null value, it raises NullPointerException.

I've fixed this issue changing in BaseVariable.cs:

 public override T SetValue(T value)
{
            T oldValue = _value;
            T newValue = base.SetValue(value);


            if(newValue != null && !newValue.Equals(oldValue)) // <---- This, null check
            {
                _event.Invoke(newValue);
            }

            return newValue;
}

Maybe it could be added to the code? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant