Skip to content
This repository has been archived by the owner on Jun 3, 2018. It is now read-only.

ws has hardcoded localhost #14

Open
pabloveliz opened this issue Jan 3, 2018 · 0 comments
Open

ws has hardcoded localhost #14

pabloveliz opened this issue Jan 3, 2018 · 0 comments

Comments

@pabloveliz
Copy link

description

When using a different hostname (like IP) the HMR still points to localhost.

reproduction

parcel 1.4.1 using 0.0.0.0 as host and accessing from another machine by IP gives this error on the console browser

fix?

I manually edited src/builtins/hmr-runtime.js changing line 19 with
' + global.location.hostname + '
as suggested on this pull from parcel https://github.com/parcel-bundler/parcel/pull/476/files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants