Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArtCNN as a filter #847

Open
octopushugger opened this issue Mar 11, 2024 · 5 comments
Open

ArtCNN as a filter #847

octopushugger opened this issue Mar 11, 2024 · 5 comments
Labels
area: effect enhancement New feature or request

Comments

@octopushugger
Copy link

Expected behavior 预期的功能

Add ArtCNN, a newer high quality scaling filter. https://github.com/Artoriuz/ArtCNN
Variant C4F16 RGB would probably make the most sense for magpie I think.

Better quality than any of the existing filters for art content. FSRCNNX might win in some cases.

DIV2K variant might be useful for certain types of content.

Alternative behavior (optional) 近似的功能(可选)

No response

@octopushugger octopushugger added the enhancement New feature or request label Mar 11, 2024
@octopushugger
Copy link
Author

I changed my mind I think C4F32 RGB probably makes more sense since it offers more benefit over the existing filters. I tested some more and the difference between 16 and 32 becomes more obvious with lower source resolutions.

@Blinue
Copy link
Owner

Blinue commented Mar 11, 2024

If we only need the RGB variants, it would be a good idea to port both ArtCNN_C4F16_RGB and ArtCNN_C4F32_RGB.

@kato-megumi
Copy link
Contributor

kato-megumi commented Mar 11, 2024

ArtCNN.zip
ArtCNN RGB variants ported to onnx. Only work with https://github.com/Blinue/Magpie/releases/tag/onnx-preview1

Personally not very impressed with its results.
PS: porting thing to onnx is magnitude easier than to hlsl.

GitHub
中文版 一个支持 ONNX 模型的实验性版本,如果遇到任何问题请在 #772 中讨论��� 如何使用 不支持通过 UI 指定 ONNX 模型,你应该编辑根目录中的 model.json。 示例: { "path": "2x_AnimeJaNai_HD_V3_UltraCompact_425k-fp16.onnx", "scale": 2, "backend": "dire...

@octopushugger
Copy link
Author

Wow that fast and I can already use it. Thank you!

@hooke007
Copy link
Collaborator

hooke007 commented May 12, 2024

https://github.com/Artoriuz/ArtCNN/tree/main/ONNX is maintained officially

GitHub
Super-Resolution Convolutional Neural Networks as GLSL shaders for mpv - Artoriuz/ArtCNN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: effect enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants