fix: chaning field type #5360 #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this chaning any field from CellController<String, String> to a CellController<SomeCellDataPB, String> caused exception. The root of problem was that _CardContent wasn't getting rebuilt when field type got changed. In CardState it was storing list of CellContext which contains only field id and row id so on changing field type the state wasn't changing. I made a new type CellMeta which stores field type alongside row id and field id and now CardState stores list of CellMeta.
Xazin
approved these changes
May 19, 2024
LucasXu0
reviewed
May 20, 2024
| (cellCtx) => CellMeta( | ||
| fieldId: cellCtx.fieldId, | ||
| rowId: cellCtx.rowId, | ||
| fieldType: fieldController.getField(cellCtx.fieldId)!.fieldType, |
There was a problem hiding this comment.
A future improvement: We are force unwrapping the value from getField everywhere. This doesn't make sense. If we are sure the value must not be null, we should change the return type of the getField function.
zoli
added a commit
to zoli/AppFlowy
that referenced
this pull request
May 21, 2024
* main: fix: unable to remove the remote selection when the user close the page on mobile (AppFlowy-IO#5376) chore: add limitation when importing csv file (AppFlowy-IO#5381) fix: infinite loop when getting ancestor for orphan view (AppFlowy-IO#5375) fix: range error raise if heading level >= 6 (AppFlowy-IO#5373) fix: use full update states instead of patch update (AppFlowy-IO#5371) chore: update translations to consistently use appName instead of AppFlowy (AppFlowy-IO#5354) fix: changing field type from text to checkbox causes exception AppFlowy-IO#5360 (AppFlowy-IO#5366) fix: heading node validate failed (AppFlowy-IO#5370) chore: support Ukrainian language AppFlowy-IO#5350 (AppFlowy-IO#5369) chore: do not use the cell of given summary field (AppFlowy-IO#5362) chore: update translations with Fink 🐦 (AppFlowy-IO#5322) chore: update fr-FR.json (AppFlowy-IO#5356) fix: workspace icon displays incorrectly on Linux (AppFlowy-IO#5358) feat: support web grid preview (AppFlowy-IO#5353)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this changing any field from CellController<String, String> to a CellController<SomeCellDataPB, String> caused an exception. The root of the problem was that _CardContent wasn't getting rebuilt when field type got changed. In CardState it was storing a list of CellContext which contains only field id and row id so on changing field type the state wasn't changing.
I made a new type CellMeta which stores field type alongside row id and field id and now CardState stores list of CellMeta.
Fixes #5360
PR Checklist