Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thumbCaptions setting creates invalid html #1810

Open
mattdyer opened this issue Oct 12, 2022 · 0 comments
Open

thumbCaptions setting creates invalid html #1810

mattdyer opened this issue Oct 12, 2022 · 0 comments

Comments

@mattdyer
Copy link

There is a thumbCaptions setting that, if set to true, looks for a data-thumbcaption attribute on the slides and uses that to add a caption to each thumbnail. This only activates if controlNav is set to "thumbnails". When it adds the caption, it appends a span to the img elements that are the thumbnails. Img elements can't contain other elements, so the captions never display.

mattdyer added a commit to mattdyer/FlexSlider that referenced this issue Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant