Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT Timestamp Invalid #193

Open
lbussy opened this issue Apr 18, 2021 · 1 comment
Open

MQTT Timestamp Invalid #193

lbussy opened this issue Apr 18, 2021 · 1 comment
Labels
breaking change This will require a major version release enhancement New feature or request

Comments

@lbussy
Copy link
Collaborator

lbussy commented Apr 18, 2021

Reported by postalbunny via PM on HBT:

{"Color":"Orange","timeStamp":1839,"fermunits":"SG","SG":"1.0260","Temp":"74.0","tempunits":"F"}
{"Color":"Orange","timeStamp":1869,"fermunits":"SG","SG":"1.0260","Temp":"74.0","tempunits":"F"}
{"Color":"Orange","timeStamp":1899,"fermunits":"SG","SG":"1.0260","Temp":"74.0","tempunits":"F"}
{"Color":"Orange","timeStamp":1930,"fermunits":"SG","SG":"1.0260","Temp":"74.0","tempunits":"F"}

I think this is actually a count-up from power on and that we're not really tracking time. I'm wondering if we should change "timestamp" to "uptime" or provide the actual timestamp. Someone mapping the mqtt may try to convert the timestamp from "epoch" and get some weird dates.

It is in fact only millis() wrapped up in `std::time(0):

payload["timeStamp"] = (int)std::time(0);

@thorrak
Copy link
Owner

thorrak commented Jan 11, 2022

As this is theoretically a breaking change, deferring this to a future version.

@thorrak thorrak added the enhancement New feature or request label Jun 4, 2023
@thorrak thorrak added the breaking change This will require a major version release label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This will require a major version release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants