Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested liveness/readiness group not working #40773

Closed
kubav182 opened this issue May 16, 2024 · 6 comments
Closed

Nested liveness/readiness group not working #40773

kubav182 opened this issue May 16, 2024 · 6 comments

Comments

@kubav182
Copy link

In SB 2.7 i could write this config

management:
  endpoint:
    health:
      show-details: always
      group:
        readiness:
          include: 'readinessState,binders/kafka,db,redis'
        liveness:
          include: 'livenessState,binders/kafka,db,redis'

but in SB3 it does not work because binders/kafka does not exist and app won't start. I can use just binders without kafka. When i look to liveness endpoint it contains binders with nested kafka. So how can i select just kafka in SB3? I tried diffferent separators like : . :/ - and nothing works. I use SB 3.2.4

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 16, 2024
@wilkinsona
Copy link
Member

Does https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.1-Release-Notes#health-group-membership-validation help? That will allow Boot to start when a member doesn't exist as it did by default in previous releases.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label May 16, 2024
@kubav182
Copy link
Author

@wilkinsona yes that works. But it is strange because I include something wrong for validation but it is really included if I skip the validation.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 16, 2024
@wilkinsona
Copy link
Member

Assuming that binders is a composite and that kafka exists as a component of that composite, I can't see a problem with the configuration that you tried. I guess you're using Spring Cloud Stream and its Kafka binder but I can't tell for certain.

If you would like us to spend some more time investigating, please spend some time providing a complete yet minimal sample that reproduces the problem. You can share it with us by pushing it to a separate repository on GitHub or by zipping it up and attaching it to this issue.

@wilkinsona wilkinsona added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels May 16, 2024
@kubav182
Copy link
Author

It will take some time to get working example with kafka locally. You are right I'm using spring cloud stream with kafka binder. The validator does not see any contributor in "binders" contributor for name "kafka". Separator / is ok as I see in code.

contributor = ((NamedContributors<?>) contributor).getContributor(path[pathOffset]); returns null for "kafka"

But in json actuator/health/rediness it is there if I skip the validation.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 16, 2024
@wilkinsona wilkinsona added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels May 16, 2024
@wilkinsona wilkinsona changed the title Nested livenes/rediness group not working Nested liveness/readiness group not working May 21, 2024
@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label May 23, 2024
@spring-projects-issues
Copy link
Collaborator

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@spring-projects-issues spring-projects-issues closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
@spring-projects-issues spring-projects-issues removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants