Support for finding fortune files from XDG_DATA_DIRS #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ralismark !
|
|
Will do! I'll split this up into a few smaller standalone PRs. |
|
On Thu, 02 Mar 2023 02:22:04 -0800 Temmie Yao ***@***.***> wrote:
Will do! I'll split this up into a few smaller standalone PRs.
thanks!
…--
Shlomi Fish https://www.shlomifish.org/
https://github.com/shlomif/Freenode-programming-channel-FAQ
If Emma Watson and Arnold Schwarzenegger were locked in a room alone, only Emma
would come out alive. After she would break the door open.
— https://www.shlomifish.org/humour/bits/facts/Emma-Watson/
Please reply to list if it's a mailing list post - https://shlom.in/reply .
|
|
Per my earlier comments, I am closing this pullreq. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #74.
This reworks support for FORTDIR/OFFDIR and LOCFORTDIR/LOCOFFDIR to support any amount of directories. I've also refactored the fortune file lookup logic to be more sensible.
My intention for the new lookup logic is as follows:
/or./or../, then treat it as absolute/relative to current directory. Don't do any further processing.-o, strip that suffix and look in offensive dirs instead of regular fortune dirs. This matches the BSD-compatibility feature.<fortdir>(out of paths in$XDG_DATA_DIR, FORTDIR, and LOCFORTDIR, or the corresponding offensive dirs):<lang>, try<fortdir>/<lang>/<name>, then try<fortdir>/<name>Does this look ok?
Remaining work:
allargument e.g.fortune 9% all