Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow on_save not working anymore in scheduler #10357

Open
attrib opened this issue Feb 8, 2024 · 0 comments
Open

Workflow on_save not working anymore in scheduler #10357

attrib opened this issue Feb 8, 2024 · 0 comments
Labels
Area: Workflow Issues & PRs related to all things regarding workflow Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate Type: Bug Bugs within the core SuiteCRM codebase

Comments

@attrib
Copy link

attrib commented Feb 8, 2024

Issue

  1. Have two modules with a relation.
  2. Create a scheduler workflow for module A which modifies the related record B
  3. Have a on save workflow for B, which calculates a value for a field in B

Expected Behavior

After the scheduler did run, record from module B, should have the calculated field set

Actual Behavior

The second workflow for module B, didn't run, so only the change from the scheduled workflow was applied.

Possible Fix

Introduced by #10296

I reverted this commit locally, but this needs rework.

Context

We have a lot of processes which depend on each other. Some of our instances using this behavior a lot.

Merging the logic of the two workflows into one workflow is only viable in this small use-case. But we have multiple workflows which would trigger the on save workflow. So we would need to add the logic from the on save workflow into all other scheduler workflows. Which then get super hard to maintain.

The PR which was merged is in my mind a big breaking change for how workflows behave.

Your Environment

  • SuiteCRM Version used: 7.14.3
  • PHP 8.2 + MySQL 8
@johnM2401 johnM2401 added Type: Bug Bugs within the core SuiteCRM codebase Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Area: Workflow Issues & PRs related to all things regarding workflow labels Feb 12, 2024
@gemartin21 gemartin21 added the Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Workflow Issues & PRs related to all things regarding workflow Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate Type: Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

3 participants