Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7zip] Add missing Windows Header #38761

Open
kcrif opened this issue May 16, 2024 · 7 comments · May be fixed by #38779
Open

[7zip] Add missing Windows Header #38761

kcrif opened this issue May 16, 2024 · 7 comments · May be fixed by #38779
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@kcrif
Copy link

kcrif commented May 16, 2024

Is your feature request related to a problem? Please describe.

With 7zip | Version: 23.01 in manifest mode, the folders

CPP\Windows
CPP\7zip\Common

are missing.

Proposed solution

Add all missing folders

Describe alternatives you've considered

No response

Additional context

No response

@kcrif kcrif added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 16, 2024
@Osyotr
Copy link
Contributor

Osyotr commented May 16, 2024

IIRC these are not public API so no reason to install it.

@kcrif
Copy link
Author

kcrif commented May 16, 2024

??

https://github.com/ip7z/7zip

Why not? Need them, works fine while using git, but with vcpkg these folders are missing.

@kcrif
Copy link
Author

kcrif commented May 16, 2024

Need NFile, NDir, IInArchive, CPropVariant etc.

@Osyotr
Copy link
Contributor

Osyotr commented May 16, 2024

Please share your usage.
NFile::/NDir::/CPropVariant are not exported from the DLL.

@jimwang118 jimwang118 linked a pull request May 17, 2024 that will close this issue
7 tasks
@kcrif
Copy link
Author

kcrif commented May 17, 2024

Have some code based on

https://github.com/ip7z/7zip/blob/main/CPP/7zip/UI/Client7z/Client7z.cpp

within this code all these files are needed

@Osyotr
Copy link
Contributor

Osyotr commented May 17, 2024

Again, this API is not exported from the DLL, so you will get linker errors if you attempt to use it.

@kcrif
Copy link
Author

kcrif commented May 17, 2024

Please try to build the provide example [Client7z] from the git folder that also comes with the download from https://7-zip.org/a/7z2301.msi. Works like a charm. Trying to use this example with vspkg the build fails. For what reason i should not be able to build the provided examples? Even why is the example not part of the Package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants