Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Types for promptflow-evals evaluator classes #3201

Open
pamelafox opened this issue May 10, 2024 · 0 comments
Open

[BUG] Types for promptflow-evals evaluator classes #3201

pamelafox opened this issue May 10, 2024 · 0 comments
Assignees
@luigiw @singankit
Labels
bug Something isn't working promptflow-evals

Comments

@pamelafox
Copy link
Member

Describe the bug

The type for config is listed as AzureOpenAIModelConfiguration:
https://github.com/microsoft/promptflow/blob/main/src/promptflow-evals/promptflow/evals/evaluators/_relevance/_relevance.py#L19

However, my hope is to also use OpenAIModelConfiguration with it, and my guess is that it's not intentionally set to Azure only. Can that type be a union or the base class?
@pamelafox pamelafox added the bug Something isn't working label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luigiw luigiw

@singankit singankit

Labels
bug Something isn't working promptflow-evals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pamelafox @luigiw @D-W- @singankit