{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":660489378,"defaultBranch":"main","name":"promptflow","ownerLogin":"microsoft","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-06-30T06:03:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6154722?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717406772.0","currentOid":""},"activityList":{"items":[{"before":"77ece8b315adfcdf89b033fe20170597deca7b56","after":"c6b223f022ddc4d2a40ac299f3b07f3a9a82aca0","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T10:39:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"fix: recording signature","shortMessageHtmlLink":"fix: recording signature"}},{"before":"b8312526473cccd14709dbc951575fbe3f3b7259","after":"77ece8b315adfcdf89b033fe20170597deca7b56","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T10:31:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"add CHANGELOG","shortMessageHtmlLink":"add CHANGELOG"}},{"before":"be2dfd300f660c82861bc4fb33989ec3b2c0d12e","after":"b8312526473cccd14709dbc951575fbe3f3b7259","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T10:27:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"daemon=True","shortMessageHtmlLink":"daemon=True"}},{"before":"866532bd8612e6c8e1098afaca3e90beee118260","after":"be2dfd300f660c82861bc4fb33989ec3b2c0d12e","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T10:23:50.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"remove unused param","shortMessageHtmlLink":"remove unused param"}},{"before":"b5ada349a010d5f80bf17f21805dcb1f28ed8dc1","after":"ee9268104ca524f821b86bfc9016290c65b3206e","ref":"refs/heads/dev/chenyin/update_credential_without_secret","pushedAt":"2024-06-03T09:53:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"YingChen1996","name":"Ying Chen","path":"/YingChen1996","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26239730?s=80&v=4"},"commit":{"message":"update recording conftest","shortMessageHtmlLink":"update recording conftest"}},{"before":null,"after":"b5ada349a010d5f80bf17f21805dcb1f28ed8dc1","ref":"refs/heads/dev/chenyin/update_credential_without_secret","pushedAt":"2024-06-03T09:26:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"YingChen1996","name":"Ying Chen","path":"/YingChen1996","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26239730?s=80&v=4"},"commit":{"message":"Merge branch 'main' into dev/chenyin/update_credential_without_secret","shortMessageHtmlLink":"Merge branch 'main' into dev/chenyin/update_credential_without_secret"}},{"before":"274284d28b07abc9654373c4cdc36f6d7b9aace7","after":"866532bd8612e6c8e1098afaca3e90beee118260","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T09:18:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"fix: remove deadlock","shortMessageHtmlLink":"fix: remove deadlock"}},{"before":"f3520901172e8dbb955cbf1d035cb32f32fd1cad","after":"274284d28b07abc9654373c4cdc36f6d7b9aace7","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T09:17:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"add flush before shutdown PFS","shortMessageHtmlLink":"add flush before shutdown PFS"}},{"before":"6ddb26743344977298d31d1f193c69c1a28f68d7","after":"f3520901172e8dbb955cbf1d035cb32f32fd1cad","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T09:02:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"fix: use .seconds to convert to int","shortMessageHtmlLink":"fix: use .seconds to convert to int"}},{"before":"db6dae2d1473f33bf8d8cf70c6a33fbdc1455859","after":"6ddb26743344977298d31d1f193c69c1a28f68d7","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T08:59:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"use telemetry logger","shortMessageHtmlLink":"use telemetry logger"}},{"before":null,"after":"50c3701b8c4e48579979be2bd654679ac816f708","ref":"refs/heads/zhrua/fix_stream","pushedAt":"2024-06-03T08:37:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lalala123123","name":"zhen","path":"/lalala123123","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17938940?s=80&v=4"},"commit":{"message":"fix failed test case","shortMessageHtmlLink":"fix failed test case"}},{"before":"78d8ada53b0574c749e3dc1dbcb99057c2a315fb","after":"db6dae2d1473f33bf8d8cf70c6a33fbdc1455859","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T08:03:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"add log telemetry for trace count","shortMessageHtmlLink":"add log telemetry for trace count"}},{"before":"287495c97b2b8b59834c808cef59c676073d7ab7","after":"c9c386a32891223dd91e9b4d6e4f84ede97a0834","ref":"refs/heads/zhrua/fix_executor_test","pushedAt":"2024-06-03T07:47:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lalala123123","name":"zhen","path":"/lalala123123","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17938940?s=80&v=4"},"commit":{"message":"revert","shortMessageHtmlLink":"revert"}},{"before":"132d20e172215be3fafdaabf25b688943ee221fa","after":"287495c97b2b8b59834c808cef59c676073d7ab7","ref":"refs/heads/zhrua/fix_executor_test","pushedAt":"2024-06-03T07:43:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lalala123123","name":"zhen","path":"/lalala123123","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17938940?s=80&v=4"},"commit":{"message":"Update requirements.txt","shortMessageHtmlLink":"Update requirements.txt"}},{"before":"1cd1fc68fb6e19a8bb35ff89cfb0809e78995ed8","after":"132d20e172215be3fafdaabf25b688943ee221fa","ref":"refs/heads/zhrua/fix_executor_test","pushedAt":"2024-06-03T07:42:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lalala123123","name":"zhen","path":"/lalala123123","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17938940?s=80&v=4"},"commit":{"message":"Update requirements.txt","shortMessageHtmlLink":"Update requirements.txt"}},{"before":null,"after":"78d8ada53b0574c749e3dc1dbcb99057c2a315fb","ref":"refs/heads/zhengfei/feature/trace-telemetry","pushedAt":"2024-06-03T06:30:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"zhengfeiwang","name":"Zhengfei Wang","path":"/zhengfeiwang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38847871?s=80&v=4"},"commit":{"message":"Adding more custom dimensions (#3356)\n\n# Description\r\n\r\nPlease add an informative description that covers that changes made by\r\nthe pull request and link all relevant issues.\r\n\r\n# All Promptflow Contribution checklist:\r\n- [ ] **The pull request does not introduce [breaking changes].**\r\n- [ ] **CHANGELOG is updated for new features, bug fixes or other\r\nsignificant changes.**\r\n- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**\r\n- [ ] **Create an issue and link to the pull request to get dedicated\r\nreview from promptflow team. Learn more: [suggested\r\nworkflow](../CONTRIBUTING.md#suggested-workflow).**\r\n\r\n## General Guidelines and Best Practices\r\n- [ ] Title of the pull request is clear and informative.\r\n- [ ] There are a small number of commits, each of which have an\r\ninformative message. This means that previously merged commits do not\r\nappear in the history of the PR. For more information on cleaning up the\r\ncommits in your PR, [see this\r\npage](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).\r\n\r\n### Testing Guidelines\r\n- [ ] Pull request includes test coverage for the included changes.","shortMessageHtmlLink":"Adding more custom dimensions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2323755525\" data-permission-text=\"Title is private\" data-url=\"https://github.com/microsoft/promptflow/issues/3356\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/microsoft/promptflow/pull/3356/hovercard\" href=\"https://github.com/microsoft/promptflow/pull/3356\">#3356</a>)"}},{"before":"6836e6a6daa31a33cda5da9d57ff081e040348a2","after":"1cd1fc68fb6e19a8bb35ff89cfb0809e78995ed8","ref":"refs/heads/zhrua/fix_executor_test","pushedAt":"2024-06-03T06:27:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"lalala123123","name":"zhen","path":"/lalala123123","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17938940?s=80&v=4"},"commit":{"message":"fix failed test case","shortMessageHtmlLink":"fix failed test case"}},{"before":null,"after":"6836e6a6daa31a33cda5da9d57ff081e040348a2","ref":"refs/heads/zhrua/fix_executor_test","pushedAt":"2024-06-03T06:08:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lalala123123","name":"zhen","path":"/lalala123123","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17938940?s=80&v=4"},"commit":{"message":"Merge branch 'main' of https://github.com/microsoft/promptflow into fix","shortMessageHtmlLink":"Merge branch 'main' of <a href=\"https://github.com/microsoft/promptflow\">https://github.com/microsoft/promptflow</a> into fix"}},{"before":"0f381b4520bd9ea95104f1b2e0b3bad9d861f6c8","after":"78d8ada53b0574c749e3dc1dbcb99057c2a315fb","ref":"refs/heads/main","pushedAt":"2024-05-31T22:37:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"nagkumar91","name":"Nagkumar Arkalgud","path":"/nagkumar91","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4727422?s=80&v=4"},"commit":{"message":"Adding more custom dimensions (#3356)\n\n# Description\r\n\r\nPlease add an informative description that covers that changes made by\r\nthe pull request and link all relevant issues.\r\n\r\n# All Promptflow Contribution checklist:\r\n- [ ] **The pull request does not introduce [breaking changes].**\r\n- [ ] **CHANGELOG is updated for new features, bug fixes or other\r\nsignificant changes.**\r\n- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**\r\n- [ ] **Create an issue and link to the pull request to get dedicated\r\nreview from promptflow team. Learn more: [suggested\r\nworkflow](../CONTRIBUTING.md#suggested-workflow).**\r\n\r\n## General Guidelines and Best Practices\r\n- [ ] Title of the pull request is clear and informative.\r\n- [ ] There are a small number of commits, each of which have an\r\ninformative message. This means that previously merged commits do not\r\nappear in the history of the PR. For more information on cleaning up the\r\ncommits in your PR, [see this\r\npage](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).\r\n\r\n### Testing Guidelines\r\n- [ ] Pull request includes test coverage for the included changes.","shortMessageHtmlLink":"Adding more custom dimensions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2323755525\" data-permission-text=\"Title is private\" data-url=\"https://github.com/microsoft/promptflow/issues/3356\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/microsoft/promptflow/pull/3356/hovercard\" href=\"https://github.com/microsoft/promptflow/pull/3356\">#3356</a>)"}},{"before":"296c4aba7892681b56d3c4fb6e1cb3b4ec90f20e","after":null,"ref":"refs/heads/task/updateCustomMetrics","pushedAt":"2024-05-31T22:37:48.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nagkumar91","name":"Nagkumar Arkalgud","path":"/nagkumar91","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4727422?s=80&v=4"}},{"before":"6c6bab5742676ceca44609bf51be1e02376f27cc","after":null,"ref":"refs/heads/users/ninhu/http_recording","pushedAt":"2024-05-31T21:53:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ninghu","name":"Billy Hu","path":"/ninghu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11171669?s=80&v=4"}},{"before":"83f3f77e33ca74e647a42288dee6889540b39157","after":"0f381b4520bd9ea95104f1b2e0b3bad9d861f6c8","ref":"refs/heads/main","pushedAt":"2024-05-31T21:53:58.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ninghu","name":"Billy Hu","path":"/ninghu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11171669?s=80&v=4"},"commit":{"message":"Enable VCR recording for evaluation e2e tests (#3348)\n\n# Description\r\n\r\nPlease add an informative description that covers that changes made by\r\nthe pull request and link all relevant issues.\r\n\r\n# All Promptflow Contribution checklist:\r\n- [ ] **The pull request does not introduce [breaking changes].**\r\n- [ ] **CHANGELOG is updated for new features, bug fixes or other\r\nsignificant changes.**\r\n- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**\r\n- [ ] **Create an issue and link to the pull request to get dedicated\r\nreview from promptflow team. Learn more: [suggested\r\nworkflow](../CONTRIBUTING.md#suggested-workflow).**\r\n\r\n## General Guidelines and Best Practices\r\n- [ ] Title of the pull request is clear and informative.\r\n- [ ] There are a small number of commits, each of which have an\r\ninformative message. This means that previously merged commits do not\r\nappear in the history of the PR. For more information on cleaning up the\r\ncommits in your PR, [see this\r\npage](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).\r\n\r\n### Testing Guidelines\r\n- [ ] Pull request includes test coverage for the included changes.","shortMessageHtmlLink":"Enable VCR recording for evaluation e2e tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2316314837\" data-permission-text=\"Title is private\" data-url=\"https://github.com/microsoft/promptflow/issues/3348\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/microsoft/promptflow/pull/3348/hovercard\" href=\"https://github.com/microsoft/promptflow/pull/3348\">#3348</a>)"}},{"before":null,"after":"61fc1f1ade7df990d8c149dbb225dd784f4e0af7","ref":"refs/heads/users/singankit/support_aggregated_metrics_if_flows_generate","pushedAt":"2024-05-31T20:52:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"singankit","name":"Ankit Singhal","path":"/singankit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30610298?s=80&v=4"},"commit":{"message":"Fixing timezone issue with local to cloud run","shortMessageHtmlLink":"Fixing timezone issue with local to cloud run"}},{"before":"a7e4043feb3b9cf6a55614e1de975a6ca8de4db2","after":null,"ref":"refs/heads/users/sinankit/telemetry_pf_evals","pushedAt":"2024-05-31T20:34:33.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"singankit","name":"Ankit Singhal","path":"/singankit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30610298?s=80&v=4"}},{"before":"9dc76da5c45fd8633d4b645a65617d7bc75cb91f","after":"83f3f77e33ca74e647a42288dee6889540b39157","ref":"refs/heads/main","pushedAt":"2024-05-31T20:34:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"singankit","name":"Ankit Singhal","path":"/singankit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30610298?s=80&v=4"},"commit":{"message":"Adding activity logger for evaluator API (#3359)\n\n# Description\r\n\r\nPlease add an informative description that covers that changes made by\r\nthe pull request and link all relevant issues.\r\n\r\n# All Promptflow Contribution checklist:\r\n- [ ] **The pull request does not introduce [breaking changes].**\r\n- [ ] **CHANGELOG is updated for new features, bug fixes or other\r\nsignificant changes.**\r\n- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**\r\n- [ ] **Create an issue and link to the pull request to get dedicated\r\nreview from promptflow team. Learn more: [suggested\r\nworkflow](../CONTRIBUTING.md#suggested-workflow).**\r\n\r\n## General Guidelines and Best Practices\r\n- [ ] Title of the pull request is clear and informative.\r\n- [ ] There are a small number of commits, each of which have an\r\ninformative message. This means that previously merged commits do not\r\nappear in the history of the PR. For more information on cleaning up the\r\ncommits in your PR, [see this\r\npage](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).\r\n\r\n### Testing Guidelines\r\n- [ ] Pull request includes test coverage for the included changes.","shortMessageHtmlLink":"Adding activity logger for evaluator API (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2326130997\" data-permission-text=\"Title is private\" data-url=\"https://github.com/microsoft/promptflow/issues/3359\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/microsoft/promptflow/pull/3359/hovercard\" href=\"https://github.com/microsoft/promptflow/pull/3359\">#3359</a>)"}},{"before":"25511be6a4d6bda4eb583d62ceeda1759114367e","after":"296c4aba7892681b56d3c4fb6e1cb3b4ec90f20e","ref":"refs/heads/task/updateCustomMetrics","pushedAt":"2024-05-31T15:41:29.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"nagkumar91","name":"Nagkumar Arkalgud","path":"/nagkumar91","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4727422?s=80&v=4"},"commit":{"message":"Merge branch 'main' into task/updateCustomMetrics","shortMessageHtmlLink":"Merge branch 'main' into task/updateCustomMetrics"}},{"before":"9bf7a6c239dc61ea6b96b9c3b49d956eb0447e08","after":null,"ref":"refs/heads/dev/robbenwang_aggregate_node","pushedAt":"2024-05-31T07:24:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"huaiyan","name":"Robben Wang","path":"/huaiyan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17527303?s=80&v=4"}},{"before":"e31d8e0e92f572b0704ad5e14e0315d2f619aa66","after":"9dc76da5c45fd8633d4b645a65617d7bc75cb91f","ref":"refs/heads/main","pushedAt":"2024-05-31T07:24:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"huaiyan","name":"Robben Wang","path":"/huaiyan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17527303?s=80&v=4"},"commit":{"message":"Ignore aggregation node for trace telemetry. (#3354)\n\n# Description\r\n\r\nIgnore aggregate node for trace telemetry.\r\nFor aggregate node trace, it doesn't have parent span, line run id or\r\nbatch run id.\r\nSo, will be wrongly marked as script execution.\r\n\r\n# All Promptflow Contribution checklist:\r\n- [ ] **The pull request does not introduce [breaking changes].**\r\n- [ ] **CHANGELOG is updated for new features, bug fixes or other\r\nsignificant changes.**\r\n- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**\r\n- [ ] **Create an issue and link to the pull request to get dedicated\r\nreview from promptflow team. Learn more: [suggested\r\nworkflow](../CONTRIBUTING.md#suggested-workflow).**\r\n\r\n## General Guidelines and Best Practices\r\n- [ ] Title of the pull request is clear and informative.\r\n- [ ] There are a small number of commits, each of which have an\r\ninformative message. This means that previously merged commits do not\r\nappear in the history of the PR. For more information on cleaning up the\r\ncommits in your PR, [see this\r\npage](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).\r\n\r\n### Testing Guidelines\r\n- [ ] Pull request includes test coverage for the included changes.\r\n\r\nCo-authored-by: robbenwang <robbenwang@microsoft.com>","shortMessageHtmlLink":"Ignore aggregation node for trace telemetry. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322379165\" data-permission-text=\"Title is private\" data-url=\"https://github.com/microsoft/promptflow/issues/3354\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/microsoft/promptflow/pull/3354/hovercard\" href=\"https://github.com/microsoft/promptflow/pull/3354\">#3354</a>)"}},{"before":"36798f93914f4f65fb119b75203ee323409f54b0","after":null,"ref":"refs/heads/heta/fix-generator-in-subflow","pushedAt":"2024-05-31T05:12:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"brynn-code","name":"Brynn Yin","path":"/brynn-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24237253?s=80&v=4"}},{"before":"618d86c20bc13c465b55f60452bd5f1b9d8734c4","after":"e31d8e0e92f572b0704ad5e14e0315d2f619aa66","ref":"refs/heads/main","pushedAt":"2024-05-31T05:12:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"brynn-code","name":"Brynn Yin","path":"/brynn-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24237253?s=80&v=4"},"commit":{"message":"[Bugfix] Fix the bug that generator in subflow would fail. (#3357)\n\n# Description\r\n\r\nBugfix for #3355 \r\n\r\nThis pull request includes a significant change in the\r\n`update_and_persist_generator_node_runs` method in the\r\n`src/promptflow-core/promptflow/_core/run_tracker.py` file. The change\r\nprimarily focuses on adding a condition to check if `api_calls` for a\r\n`node_run_info` exists before proceeding with the update. This change is\r\nimportant as it takes into account scenarios where `api_calls` for the\r\nnode run might not exist, such as in a flow as function/serving. In such\r\ncases, the update is skipped.\r\n\r\nAdditionally, the method of accessing the `output` from `api_calls` has\r\nbeen changed from direct indexing to using the `get` method, which is a\r\nsafer way to access dictionary values.\r\n\r\n*\r\n[`src/promptflow-core/promptflow/_core/run_tracker.py`](diffhunk://#diff-a5027d19a24cb28a68ead16dfe6c54492c78d6e0e7640e80533928808cdb3422R451-R457):\r\nAdded a condition to check if `api_calls` exists for `node_run_info`\r\nbefore updating it. This accounts for scenarios where `api_calls` for\r\nthe node run might not exist. Also, changed the way `output` is accessed\r\nfrom `api_calls` by using the `get` method instead of direct indexing.\r\n# All Promptflow Contribution checklist:\r\n- [ ] **The pull request does not introduce [breaking changes].**\r\n- [ ] **CHANGELOG is updated for new features, bug fixes or other\r\nsignificant changes.**\r\n- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**\r\n- [ ] **Create an issue and link to the pull request to get dedicated\r\nreview from promptflow team. Learn more: [suggested\r\nworkflow](../CONTRIBUTING.md#suggested-workflow).**\r\n\r\n## General Guidelines and Best Practices\r\n- [ ] Title of the pull request is clear and informative.\r\n- [ ] There are a small number of commits, each of which have an\r\ninformative message. This means that previously merged commits do not\r\nappear in the history of the PR. For more information on cleaning up the\r\ncommits in your PR, [see this\r\npage](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).\r\n\r\n### Testing Guidelines\r\n- [ ] Pull request includes test coverage for the included changes.\r\n\r\n---------\r\n\r\nSigned-off-by: Brynn Yin <biyi@microsoft.com>\r\nCo-authored-by: Heyi <heta@microsoft.com>\r\nCo-authored-by: Brynn Yin <biyi@microsoft.com>","shortMessageHtmlLink":"[Bugfix] Fix the bug that generator in subflow would fail. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2324619288\" data-permission-text=\"Title is private\" data-url=\"https://github.com/microsoft/promptflow/issues/3357\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/microsoft/promptflow/pull/3357/hovercard\" href=\"https://github.com/microsoft/promptflow/pull/3357\">#3357</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWtBXOQA","startCursor":null,"endCursor":null}},"title":"Activity · microsoft/promptflow"}