Indicates whether Roslyn is included #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
requested changes
Dec 10, 2020
|
I could expose instance as a parameter as I have ContainsRoslynCompiler exposed here. Would you want the non-VS versions to return null for that? |
|
Hi @rainersigwald and @Forgind, Do we plan to work on this PR? |
|
I think we need to have a design for #22 before taking any implementation and would favor closing this. |
|
I think this is low enough priority that it doesn't warrant a serious design discussion. I'd personally prefer to just take this roughly as-is over closing it, but closing it makes more sense than talking about it for too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
I didn't see an obvious way to determine whether the C# compiler was installed for the dotnet sdk, and I didn't want to replicate all the logic from VSLocationHelper for a command prompt. Maybe right?