Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetBlobMetaData and SetBlobMetaData procedure to ABS Blob Client codeunit #969

Merged
merged 17 commits into from
May 24, 2024
Merged

Add GetBlobMetaData and SetBlobMetaData procedure to ABS Blob Client codeunit #969

merged 17 commits into from
May 24, 2024

Conversation

Indubhusan23
Copy link
Contributor

@Indubhusan23 Indubhusan23 commented Apr 22, 2024 •
edited by github-actions bot

Summary

In codeunit 9053 ABS Blob Client there is a procedure with several overloads GetBlobTags that allows us to get the tags associated with a particular blob in the Azure Blob Storage container. The tags can be retrieved as either an XmlDocument or Dictionary[Text, Text].

I added similar procedures GetBlobMetaData and SetBlobMetaData to allow us to also Get/Set the metadata associated with a particular blob using ABS Blob Client.

Work Item(s)

Fixes #976

Fixes AB#532988

@Indubhusan23 Indubhusan23 requested a review from a team as a code owner April 22, 2024 22:35
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Apr 22, 2024
@Indubhusan23
Copy link
Contributor Author

@Indubhusan23 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Zig"

@JesperSchulz
Copy link
Contributor

Moving the issue from ALAppExtensions to BCApps for triage.

@JesperSchulz JesperSchulz linked an issue Apr 23, 2024 that may be closed by this pull request
[Request] Add GetBlobMetadata procedure to ABS Blob Client codeunit #976
Closed
Indubhusan23 and others added 5 commits April 29, 2024 19:32
@Indubhusan23 @darjoo
Update src/System Application/App/Azure Blob Services API/src/ABSOper…
89ab822 
…ationResponse.Codeunit.al

Co-authored-by: Darrick <darjoo@users.noreply.github.com>
@Indubhusan23 @darjoo
Update src/System Application/App/Azure Blob Services API/src/ABSClie…
2645e59 
…ntImpl.Codeunit.al

Co-authored-by: Darrick <darjoo@users.noreply.github.com>
@Indubhusan23 @darjoo
Update src/System Application/App/Azure Blob Services API/src/ABSOper…
c09bce2 
…ationResponse.Codeunit.al

Co-authored-by: Darrick <darjoo@users.noreply.github.com>
@Indubhusan23
updated spelling of procedure
d95fb8e
@Indubhusan23
Merge branch 'main' of https://github.com/Indubhusan23/BCApps
d71a8f0
@JesperSchulz JesperSchulz added Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item labels Apr 30, 2024
@github-actions github-actions bot modified the milestone: Version 25.0 Apr 30, 2024
Indubhusan23 and others added 4 commits April 30, 2024 09:52
@Indubhusan23 @grobyns
Update src/System Application/App/Azure Blob Services API/src/ABSBlob…
f2fdc81 
…Client.Codeunit.al

Co-authored-by: Gert Robyns <grobyns@users.noreply.github.com>
@Indubhusan23 @grobyns
Update src/System Application/App/Azure Blob Services API/src/ABSBlob…
607502f 
…Client.Codeunit.al

Co-authored-by: Gert Robyns <grobyns@users.noreply.github.com>
@Indubhusan23 @grobyns
Update src/System Application/App/Azure Blob Services API/src/ABSBlob…
8fc57e1 
…Client.Codeunit.al

Co-authored-by: Gert Robyns <grobyns@users.noreply.github.com>
@Indubhusan23 @grobyns
Update src/System Application/App/Azure Blob Services API/src/ABSBlob…
0022a81 
…Client.Codeunit.al

Co-authored-by: Gert Robyns <grobyns@users.noreply.github.com>
@JesperSchulz
Copy link
Contributor

@Indubhusan23, once the test is disabled and the merge conflict is resolved, we'll take another look at this one and get it ready for merging.

@Indubhusan23
Copy link
Contributor Author

@Indubhusan23, once the test is disabled and the merge conflict is resolved, we'll take another look at this one and get it ready for merging.
@JesperSchulz disabled the unit test and resolved the merge conflicts

@JesperSchulz JesperSchulz self-assigned this May 16, 2024
@Indubhusan23
Copy link
Contributor Author

@JesperSchulz can you have a look on this PR as you requested i have disabled the unit test and the solved the merge conflict.

@Indubhusan23 Indubhusan23 reopened this May 23, 2024
JesperSchulz
JesperSchulz approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@JesperSchulz JesperSchulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@JesperSchulz JesperSchulz merged commit f5cb5a2 into microsoft:main May 24, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grobyns grobyns grobyns left review comments

@darjoo darjoo darjoo approved these changes

@JesperSchulz JesperSchulz JesperSchulz approved these changes

Assignees

@JesperSchulz JesperSchulz

Labels
AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item
Projects
None yet
Milestone
Version 25.0
Development

Successfully merging this pull request may close these issues.

[Request] Add GetBlobMetadata procedure to ABS Blob Client codeunit
4 participants
@Indubhusan23 @JesperSchulz @darjoo @grobyns