Allow setting SASToken as SecretText in Storage Service Authorization #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AL: System Application
From Fork
darjoo
reviewed
May 6, 2024
...ation/App/Azure Storage Services Authorization/src/ReadySAS/StorServAuthReadySAS.Codeunit.al
Outdated
Show resolved
Hide resolved
darjoo
reviewed
May 7, 2024
...ation/App/Azure Storage Services Authorization/src/ReadySAS/StorServAuthReadySAS.Codeunit.al
Outdated
Show resolved
Hide resolved
...ation/App/Azure Storage Services Authorization/src/ReadySAS/StorServAuthReadySAS.Codeunit.al
Outdated
Show resolved
Hide resolved
...ation/App/Azure Storage Services Authorization/src/ReadySAS/StorServAuthReadySAS.Codeunit.al
Outdated
Show resolved
Hide resolved
...ication/App/Azure Storage Services Authorization/src/StorageServiceAuthorization.Codeunit.al
Show resolved
Hide resolved
...System Application/App/Azure Storage Services Authorization/src/StorServAuthImpl.Codeunit.al
Show resolved
Hide resolved
JesperSchulz
approved these changes
May 24, 2024
darjoo
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently you can set SASToken only as Text. Adding an overload with a SecretText parameter allowes to secure the value from isolated storage to Auth Codeunit.
Work Item(s)
Fixes #895
Fixes AB#524632