Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] #845 Added No. Series Where-Used #846

Closed

Conversation

christianbraeunlich
Copy link
Contributor

@christianbraeunlich christianbraeunlich commented Mar 29, 2024

Summary

This is a Draft PR. There's still a lot to do.

  • Adding tables manually (like in the G/L Account) or search for all "Table Relations Metadata" with "Related Table ID" + "Related Field No." set to No. Series / Code (this is my prefered way).
  • Fix PageManagement so that the user can open the page from the Where-Used results.
  • Obsolete
  • Field with TableRelation = No. Series has value or not
  • (Optional) Count
  • automated tests

Manually transfered from https://github.com/microsoft/BusinessCentralApps/pull/427

Work Item(s)

Fixes #845

@christianbraeunlich christianbraeunlich requested a review from a team as a code owner March 29, 2024 13:27
@github-actions github-actions bot added AL: Business Foundation From Fork Pull request is coming from a fork labels Mar 29, 2024
Copy link
Contributor

@NKarolak NKarolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some super-minor findings along your way :-)
I did not check the business logic itself.

TempNoSeriesWhereUsed: Record "No. Series Where-Used" temporary;
NextEntryNo: Integer;

procedure ShowSetupForm(NoSeriesWhereUsed: Record "No. Series Where-Used")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Form"? :-)

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Apr 22, 2024
…reUsed.Codeunit.al

Co-authored-by: Natalie Karolak <34504100+NKarolak@users.noreply.github.com>
Copy link
Contributor Author

@christianbraeunlich christianbraeunlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply suggestions from code review

Co-authored-by: Natalie Karolak <34504100+NKarolak@users.noreply.github.com>
@JesperSchulz
Copy link
Contributor

Hi @christianbraeunlich,

we've been discussing your PR a little and we're now having some doubts about its validity. While it makes a ton of sense to be able to see where a No. Series is used, we're not sure that this feature should be build in the way it's being built right now. In AI, "where used" is a rather prominent capability, which must be generally available for all entity relationships. You will probably see some advancements in this area in the near future, and I hence think it makes sense to wait to add this capability, until we know what the future holds here.

If you agree, I'd suggest to close this DRAFT for now and pick it up again, once we know more.

What do you say?

@christianbraeunlich
Copy link
Contributor Author

I completely 100% agree. Once I moved the code into the business foundation layer, everything felt out of place, and even before that, there's a need for more general functionality that would benefit all the other modules. So a WhereUsed module would make perfect sense. The same goes for the approval workflows imho, but I'll get to that in the otter PR.

@JesperSchulz
Copy link
Contributor

Good to hear that you've made the same observations 😊 Let's see what the future holds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AL: Business Foundation From Fork Pull request is coming from a fork Integration GitHub request for Integration area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BC Idea]: 'Where-used' No. Series
4 participants