Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BC Idea]: Add PUT method to Graph API Module #748

Open
1 task done
devgar opened this issue Mar 14, 2024 · 8 comments · Fixed by #773 or #960
Open
1 task done

[BC Idea]: Add PUT method to Graph API Module #748

devgar opened this issue Mar 14, 2024 · 8 comments · Fixed by #773 or #960
Assignees
@devgar
Labels
Approved The issue is approved

Comments

@devgar
Copy link
Contributor

devgar commented Mar 14, 2024

BC Idea Link

https://experience.dynamics.com/ideas/idea/?ideaid=160fc653-dde1-ee11-a73e-002248504629

Description

Currently Graph API module's "Graph Client" Codeunit has Get, Post, Patch and Delete Methods but lacks a PUT method which is also required for some microsoft graph requests.

It also lacks OPTIONS and HEAD methods which are common HTTP Methods but I don't realy know if they are common on Microsoft Graph.

I propose to include the PUT method, I have an initial implementation which could be included through pull request on GitHub.

I will provide the implementation for this BC Idea

  • I will provide the implementation for this BC Idea
@duichwer
Copy link

I'm really looking forward to this PR.
I know that there are missing some parts in the Microsoft Graph Module, but I didn't had the time to make this module complete.

@JesperSchulz JesperSchulz added the Approved The issue is approved label Mar 15, 2024
@JesperSchulz
Copy link
Contributor

Based on @duichwer's comment, this seems to be something we want 😉 Approved.

@duichwer
Copy link

@devgar I don't know any endpoints of the Microsoft Graph API that support HEAD or OPTIONS request.
If you find some then please show them and they can be added, too.
The general documentation doesn't mention them
https://learn.microsoft.com/en-us/graph/use-the-api#http-methods

@devgar devgar mentioned this issue Mar 18, 2024
Merged
JesperSchulz pushed a commit that referenced this issue Mar 20, 2024
@devgar
[BC Idea] Add Put method to 'Graph Client' Codeunit (#773)
790ac37 
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
This implement's HTTP Put Method in Graph API Wrapper.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes #748


Fixes
[AB#507963](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/507963)
@devgar
Copy link
Contributor Author

devgar commented Mar 20, 2024

Excellent, In what release version will it be available in?

@JesperSchulz
Copy link
Contributor

Excellent, In what release version will it be available in?

Unfortunately the change came in too late to be part of the April release (24.0). By default your changes will hence release with the next major (25.0 in October), but if you need them sooner, we can backport your changes to release with version 24.1 in May.

@devgar
Copy link
Contributor Author

devgar commented Mar 25, 2024

It would feel great if it fits in 24.1 or 24.2

@JesperSchulz
Copy link
Contributor

You got it! I'll make sure it releases with 24.1 🙂

JesperSchulz pushed a commit that referenced this issue Apr 18, 2024
@devgar @JesperSchulz
[BC Idea] Add Put method to 'Graph Client' Codeunit (#773)
48270f6 
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
This implement's HTTP Put Method in Graph API Wrapper.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes #748


Fixes
[AB#507963](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/507963)
@JesperSchulz JesperSchulz mentioned this issue Apr 18, 2024
Merged
@JesperSchulz
Copy link
Contributor

Reopening to backport to 24.x.

@JesperSchulz JesperSchulz reopened this Apr 18, 2024
@JesperSchulz JesperSchulz linked a pull request Apr 18, 2024 that will close this issue
[24.x][BC Idea] Add Put method to 'Graph Client' Codeunit (#773) #960
Merged
JesperSchulz added a commit that referenced this issue Apr 18, 2024
@JesperSchulz @devgar
[24.x][BC Idea] Add Put method to 'Graph Client' Codeunit (#773) (#960)
5459ec6 
Backport of #773
Fixes #748
Fixes
[AB#522599](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/522599)

Co-authored-by: Edgar Albalate Ibañez <dev.gardo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devgar devgar

Labels
Approved The issue is approved
Projects
None yet
Milestone
No milestone
3 participants
@devgar @duichwer @JesperSchulz