Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choosing the fields to Join On Resets Join Type in the GUI Editor #42858

Open
ixipixi opened this issue May 17, 2024 · 0 comments
Open

Choosing the fields to Join On Resets Join Type in the GUI Editor #42858

ixipixi opened this issue May 17, 2024 · 0 comments
Labels
Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Type:Bug Product defects

Comments

@ixipixi
Copy link
Contributor

ixipixi commented May 17, 2024

Describe the bug

If you join two tables in the GUI editor and set the join type to anything other than the default join, choosing the fields to join on causes the join type to revert to default.

To Reproduce

  1. In the Sample Database start a Question with "Accounts"
  2. Add a join to "People"
  3. Change the join type to "Inner Join"
  4. Choose columns to join on (like email)
  5. Join type from initial step reverts to "left outer"

Expected behavior

If the user changes the join type it should remain unless they change it.

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "Win32",
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.23+9",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "11.0.23",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.23+9",
    "os.name": "Linux",
    "os.version": "5.15.133.1-microsoft-standard-WSL2",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "h2",
      "postgres"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "11.22 (Debian 11.22-1.pgdg110+1)"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.7.2"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2024-05-09",
      "tag": "v1.49.9",
      "hash": "c0913c7"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity

annoying and inobvious

Additional context

No response

@ixipixi ixipixi added Type:Bug Product defects .Needs Triage labels May 17, 2024
@zbodi74 zbodi74 added Querying/GUI Query builder catch-all, including simple mode Priority:P2 Average run of the mill bug and removed .Needs Triage labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

2 participants