✅ Fixed filtering by producer/magazine on anime/manga search endpoints #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- additionally improved model factories for tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
============================================
+ Coverage 57.45% 57.76% +0.30%
Complexity 1352 1352
============================================
Files 339 339
Lines 5209 5209
============================================
+ Hits 2993 3009 +16
+ Misses 2216 2200 -16 ☔ View full report in Codecov by Sentry. |
irfan-dahir
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517
Currently if you search by producer or magazine on anime/manga search endpoints respectively together with other filter parameters, you won't get back any results because the database query for the search was constructed incorrectly.
This PR fixes that problem.
Additional changes:
getOverridesFromQueryStringParametersmethod will manufacture the correct models when asked with these params.