Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations to the manifest during container building in github actions #458

Open
pushrbx opened this issue Nov 27, 2023 · 1 comment · Fixed by #475
Open

Add annotations to the manifest during container building in github actions #458

pushrbx opened this issue Nov 27, 2023 · 1 comment · Fixed by #475

Comments

@pushrbx
Copy link
Collaborator

pushrbx commented Nov 27, 2023

There is a new version of docker/build-push-action which allows adding annotations. This will fix the blank package information sections on the packages page at https://github.com/jikan-me/jikan-rest/pkgs/container/jikan-rest/144357164?tag=v4.1.1

The github action to deploy containers should be modified to add the annotations.

New version:
https://github.com/docker/build-push-action/releases/tag/v5.1.0

@pushrbx
Copy link
Collaborator Author

pushrbx commented Jan 21, 2024

That change didn't work, because I didn't know that the annotations should be "index" level not "manifest" level (which is the default).

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#labelling-container-images

Reopening this issue.

@pushrbx pushrbx reopened this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant