Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade photoswipe and remove vendoring #26447

Closed
rutwikhdev opened this issue May 16, 2024 · 0 comments · Fixed by #26487
Closed

Upgrade photoswipe and remove vendoring #26447

rutwikhdev opened this issue May 16, 2024 · 0 comments · Fixed by #26487
Assignees

Comments

@rutwikhdev
Copy link
Contributor

Current version is 9 years old and some features like zoom, load more don't event work.

Error logs:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getBoundingClientRect')
    at image_view.js:235:17
    at Array.map (<anonymous>)
    at image_view.js:223:29
    at new Promise (<anonymous>)
    at frappe.views.GalleryView.prepare_pswp_items (image_view.js:222:10)
    at image_view.js:49:18
    at Rt (jquery.js:3479:29)
    at di (jquery.js:3547:12)
    at r (helpers.ts:98:1)
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'firstChild')
    at Object.getChildByClass (<anonymous>:66:23)
    at PhotoSwipe.init (<anonymous>:825:30)
    at frappe.views.GalleryView._show (image_view.js:287:13)
    at image_view.js:253:72
@rutwikhdev rutwikhdev self-assigned this May 16, 2024
@rutwikhdev rutwikhdev linked a pull request May 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant