Clang tidy not picking up all diagnostics in some code #148524
Labels
c: tech-debt
Technical debt, code quality, testing, etc.
engine
flutter/engine repository. See also e: labels.
team-engine
Owned by Engine team
I see a warning in my IDE (via
clangd
) inshell/platform/android/android_display.cc
:However, it isn't linted (either on CI or locally, i.e. with
./ci/clang_tidy.sh --variant android_debug_unopt_arm64
.@christopherfujino and I suspected maybe my configuration locally is different, there are different binaries, a bug in the rule, etc, but interestingly enough in another file (
impeller/renderer/shader_library.cc
) if I remove the opt-out (// NOLINT(performance-unnecessary-value-param)
) it does trigger:Even more interesting, the same lint will get flagged if I add another case of it in the same file:
This is also linted in the same file:
So either there is something specific about why
AndroidDisplay::AndroidDisplay
isn't linted, or its a clang-tidy bug.The text was updated successfully, but these errors were encountered: