Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DisplayListBuilder sets the opacity peephole flag despite conflicting saveLayer properties #148505

Open
flar opened this issue May 16, 2024 · 0 comments
Open

DisplayListBuilder sets the opacity peephole flag despite conflicting saveLayer properties #148505

flar opened this issue May 16, 2024 · 0 comments
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@flar
Copy link
Contributor

flar commented May 16, 2024

Currently the flag in the SaveLayer command that is passed to dispatchers only really indicates that the contents are compatible, but the presence of a backdrop filter or if the blend attributes of the SaveLayer blit are not SrcOver are also incompatible with doing the optimization. The DL should include those properties in the flag to reduce added tests in the dispatchers for these same conditions...
@flar flar mentioned this issue May 16, 2024
Merged
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team and removed in triage Presently being triaged by the triage team labels May 17, 2024
@jonahwilliams jonahwilliams added P3 Issues that are less important to the Flutter project triaged-engine Triaged by Engine team labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
Display List
Status: 🤔 Needs Triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonahwilliams @flar @danagbemava-nc