Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Relevant actions are missing when right clicking recent files #15418

Open
yaira2 opened this issue May 16, 2024 · 6 comments
Open

Bug: Relevant actions are missing when right clicking recent files #15418

yaira2 opened this issue May 16, 2024 · 6 comments
Assignees
Labels
bug Something isn't working 👀

Comments

@yaira2
Copy link
Member

yaira2 commented May 16, 2024

Description

The option to run exe files is missing when right clicking items in the Recent Files widget.

Steps To Reproduce

  1. Right click exe file from the Recent Files widget
  2. Notice that the "Run as admin" option isn't displayed

Requirements

  • display the "Run as admin" option when right clicking eligible files in the Recent Files widget
  • display the "Run as another user" option when right clicking eligible files in the Recent Files widget
  • display "Set as background" menu when right clicking eligible files in the Recent Files widget

Those are just a few examples, there are other actions as well.

Files Version

v3.4.1

Windows Version

Windows 11

Log File

NA

@yaira2 yaira2 added bug Something isn't working 👀 good first issue Good issue for new contributors to get started with labels May 16, 2024
@16dango
Copy link

16dango commented May 19, 2024

@yaira2 Could I work on this?

@Josh65-2201
Copy link
Member

Yes

@yaira2 yaira2 changed the title Bug: Run as admin action is missing when right clicking recent files Bug: Relevant actions are missing when right clicking recent files May 20, 2024
@yaira2 yaira2 added help wanted Extra attention is needed and removed good first issue Good issue for new contributors to get started with labels May 20, 2024
@yaira2 yaira2 pinned this issue May 23, 2024
@0x5bfa
Copy link
Member

0x5bfa commented May 30, 2024

Add them into RecentFilesWidgetViewModel and create commands only for home page.

new ContextMenuFlyoutItemViewModelBuilder(Commands.RunAsAdmin).Build(),
new ContextMenuFlyoutItemViewModelBuilder(Commands.RunAsAnotherUser).Build(),

new ContextMenuFlyoutItemViewModel()
{
Text = "BaseLayoutItemContextFlyoutSetAs/Text".GetLocalizedResource(),
ShowItem = itemsSelected && (selectedItemsPropertiesViewModel?.IsSelectedItemImage ?? false),
ShowInSearchPage = true,
Items =
[
new ContextMenuFlyoutItemViewModelBuilder(Commands.SetAsWallpaperBackground).Build(),
new ContextMenuFlyoutItemViewModelBuilder(Commands.SetAsLockscreenBackground).Build(),
new ContextMenuFlyoutItemViewModelBuilder(Commands.SetAsSlideshowBackground).Build(),
new ContextMenuFlyoutItemViewModelBuilder(Commands.SetAsAppBackground).Build(),
]
},

This is not help wanted Extra attention is needed .

Ultimately, we should use unified context menu builder instead of spreading around widget view models.

@yaira2
Copy link
Member Author

yaira2 commented May 30, 2024

@0x5bfa we've been working towards a single context menu builder.

@yaira2 yaira2 removed the help wanted Extra attention is needed label May 30, 2024
@yaira2
Copy link
Member Author

yaira2 commented May 30, 2024

@0x5bfa how about the "Set as" options? Do we have a way to check if the right clicked item is an image?

@0x5bfa
Copy link
Member

0x5bfa commented May 30, 2024

@0x5bfa how about the "Set as" options? Do we have a way to check if the right clicked item is an image?

I think theres extension check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👀
Projects
Status: 🏗 In progress
Development

No branches or pull requests

4 participants