{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":10270250,"defaultBranch":"main","name":"react","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-05-24T16:15:54.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717470603.0","currentOid":""},"activityList":{"items":[{"before":"c3e627456639fc8e989984e8fefbede6bd2c7862","after":"59b1f857fe561a7048186dd80b3713c36d17ac28","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-05T23:57:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"feat<Compiler>: consider that the dispatch function from `useReducer` is non-reactive (#29705)\n\nSummary\nThe dispatch function from useReducer is stable, so it is also non-reactive.\n\nthe related PR: #29665\nthe related comment: #29674 (comment)\n\nI am not sure if the location of the new test file is appropriate😅.\n\nHow did you test this change?\nAdded the specific test compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/useReducer-returned-dispatcher-is-non-reactive.expect.md.\n\nDiffTrain build for commit https://github.com/facebook/react/commit/704aeed022f4277cd5604bf6d76199a6cfe4707f.","shortMessageHtmlLink":"feat&lt;Compiler&gt;: consider that the dispatch function from <code>useReducer</code>…"}},{"before":"3730b40e9bbacef0279f6d120b344c1544cb38ba","after":"704aeed022f4277cd5604bf6d76199a6cfe4707f","ref":"refs/heads/main","pushedAt":"2024-06-05T23:51:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"josephsavona","name":"Joseph Savona","path":"/josephsavona","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6425824?s=80&v=4"},"commit":{"message":"feat<Compiler>: consider that the dispatch function from `useReducer` is non-reactive (#29705)\n\nSummary\r\nThe dispatch function from useReducer is stable, so it is also non-reactive.\r\n\r\nthe related PR: #29665\r\nthe related comment: #29674 (comment)\r\n\r\nI am not sure if the location of the new test file is appropriate😅.\r\n\r\nHow did you test this change?\r\nAdded the specific test compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/useReducer-returned-dispatcher-is-non-reactive.expect.md.","shortMessageHtmlLink":"feat&lt;Compiler&gt;: consider that the dispatch function from <code>useReducer</code>…"}},{"before":"eb259b5d3b20b053dc0444e6ae442774c396c4a7","after":"3730b40e9bbacef0279f6d120b344c1544cb38ba","ref":"refs/heads/main","pushedAt":"2024-06-05T18:58:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoxyq","name":"Ruslan Lesiutin","path":"/hoxyq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28902667?s=80&v=4"},"commit":{"message":"chore[react-devtools]: ip => internal-ip (#29772)\n\n## Summary\r\n\r\nThere was an attempt to upgrade `ip` to 2.0.1 to mitigate CVE in\r\nhttps://github.com/facebook/react/pull/29725#issuecomment-2150389616,\r\nbut there actually another one CVE in version `2.0.1`. Instead, migrate\r\nto `internal-ip`, which similarly small package that we can use\r\n\r\nNote: not upgrading to version 7+, because they are pure ESM.\r\n\r\n## How did you test this change?\r\n\r\nValidated that standalone version of RDT works and connects to the app.","shortMessageHtmlLink":"chore[react-devtools]: ip =&gt; internal-ip (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2336596809\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29772\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29772/hovercard\" href=\"https://github.com/facebook/react/pull/29772\">#29772</a>)"}},{"before":"d3308e2254696f6a62b78950d08e9e21b903b631","after":"e0ef1b20bca0df49667f9226e879c87516e3a488","ref":"refs/heads/builds/facebook-www","pushedAt":"2024-06-05T14:12:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Add enableShallowPropDiffing feature flag (#29664)\n\n## Summary\n\nWe currently do deep diffing for object props, and also use custom\ndiffers, if they are defined, for props with custom attribute config.\n\nThe idea is to simply do a `===` comparison instead of all that work. We\nwill do less computation on the JS side, but send more data to native.\n\nThe hypothesis is that this change should be neutral in terms of\nperformance. If that's the case, we'll be able to get rid of custom\ndiffers, and be one step closer to deleting view configs.\n\nThis PR adds the `enableShallowPropDiffing` feature flag to support this\nexperiment.\n\n## How did you test this change?\n\nWith `enableShallowPropDiffing` hardcoded to `true`:\n```\nyarn test packages/react-native-renderer\n```\nThis fails on the following test cases:\n- should use the diff attribute\n- should do deep diffs of Objects by default\n- should skip deeply-nested changed functions\n\nWhich makes sense with this change. These test cases should be deleted\nif the experiment is shipped.\n\nDiffTrain build for [eb259b5d3b20b053dc0444e6ae442774c396c4a7](https://github.com/facebook/react/commit/eb259b5d3b20b053dc0444e6ae442774c396c4a7)","shortMessageHtmlLink":"Add enableShallowPropDiffing feature flag (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325415534\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29664\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29664/hovercard\" href=\"https://github.com/facebook/react/pull/29664\">#29664</a>)"}},{"before":"612c599870a8f9ec187f72b4a79a551505222f81","after":"c3e627456639fc8e989984e8fefbede6bd2c7862","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-05T14:12:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Add enableShallowPropDiffing feature flag (#29664)\n\n## Summary\n\nWe currently do deep diffing for object props, and also use custom\ndiffers, if they are defined, for props with custom attribute config.\n\nThe idea is to simply do a `===` comparison instead of all that work. We\nwill do less computation on the JS side, but send more data to native.\n\nThe hypothesis is that this change should be neutral in terms of\nperformance. If that's the case, we'll be able to get rid of custom\ndiffers, and be one step closer to deleting view configs.\n\nThis PR adds the `enableShallowPropDiffing` feature flag to support this\nexperiment.\n\n## How did you test this change?\n\nWith `enableShallowPropDiffing` hardcoded to `true`:\n```\nyarn test packages/react-native-renderer\n```\nThis fails on the following test cases:\n- should use the diff attribute\n- should do deep diffs of Objects by default\n- should skip deeply-nested changed functions\n\nWhich makes sense with this change. These test cases should be deleted\nif the experiment is shipped.\n\nDiffTrain build for commit https://github.com/facebook/react/commit/eb259b5d3b20b053dc0444e6ae442774c396c4a7.","shortMessageHtmlLink":"Add enableShallowPropDiffing feature flag (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325415534\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29664\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29664/hovercard\" href=\"https://github.com/facebook/react/pull/29664\">#29664</a>)"}},{"before":"8d87e374ac69904012530af702af1cd51d90e07d","after":"eb259b5d3b20b053dc0444e6ae442774c396c4a7","ref":"refs/heads/main","pushedAt":"2024-06-05T14:07:58.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dmytrorykun","name":"Dmytro Rykun","path":"/dmytrorykun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14206200?s=80&v=4"},"commit":{"message":"Add enableShallowPropDiffing feature flag (#29664)\n\n## Summary\r\n\r\nWe currently do deep diffing for object props, and also use custom\r\ndiffers, if they are defined, for props with custom attribute config.\r\n\r\nThe idea is to simply do a `===` comparison instead of all that work. We\r\nwill do less computation on the JS side, but send more data to native.\r\n\r\nThe hypothesis is that this change should be neutral in terms of\r\nperformance. If that's the case, we'll be able to get rid of custom\r\ndiffers, and be one step closer to deleting view configs.\r\n\r\nThis PR adds the `enableShallowPropDiffing` feature flag to support this\r\nexperiment.\r\n\r\n## How did you test this change?\r\n\r\nWith `enableShallowPropDiffing` hardcoded to `true`:\r\n```\r\nyarn test packages/react-native-renderer\r\n```\r\nThis fails on the following test cases:\r\n- should use the diff attribute\r\n- should do deep diffs of Objects by default\r\n- should skip deeply-nested changed functions\r\n\r\nWhich makes sense with this change. These test cases should be deleted\r\nif the experiment is shipped.","shortMessageHtmlLink":"Add enableShallowPropDiffing feature flag (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325415534\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29664\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29664/hovercard\" href=\"https://github.com/facebook/react/pull/29664\">#29664</a>)"}},{"before":"ea1a15c39aae5032d4d7df4395bcf4874d25e2d8","after":"612c599870a8f9ec187f72b4a79a551505222f81","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-05T10:23:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Fix #29724: `ip` dependency update for CVE-2024-29415 (#29725)\n\n## Summary\n\nThis version update of `ip` dependency solves the CVE-2024-29415\nvulnerability.\n\nDiffTrain build for commit https://github.com/facebook/react/commit/8d87e374ac69904012530af702af1cd51d90e07d.","shortMessageHtmlLink":"<span class=\"issue-keyword tooltipped tooltipped-se\" aria-label=\"This commit closes issue #29724.\">Fix</span> <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2330881837\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29724\" data-hovercard-type=\"issue\" data-hovercard-url=\"/facebook/react/issues/29724/hovercard\" href=\"https://github.com/facebook/react/issues/29724\">#29724</a>: <code>ip</code> dependency update for <a title=\"CVE-2024-29415\" data-hovercard-type=\"advisory\" data-hovercard-url=\"/advisories/GHSA-2p57-rm9w-gvfp/hovercard\" href=\"https://github.com/advisories/GHSA-2p57-rm9w-gvfp\">CVE-2024-29415</a> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2330914987\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29725\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29725/hovercard\" href=\"https://github.com/facebook/react/pull/29725\">#29725</a>)"}},{"before":"1df34bdf626af3e4566364dcdf7f1c387d2f4252","after":"8d87e374ac69904012530af702af1cd51d90e07d","ref":"refs/heads/main","pushedAt":"2024-06-05T10:17:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hoxyq","name":"Ruslan Lesiutin","path":"/hoxyq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/28902667?s=80&v=4"},"commit":{"message":"Fix #29724: `ip` dependency update for CVE-2024-29415 (#29725)\n\n## Summary\r\n\r\nThis version update of `ip` dependency solves the CVE-2024-29415\r\nvulnerability.","shortMessageHtmlLink":"<span class=\"issue-keyword tooltipped tooltipped-se\" aria-label=\"This commit closes issue #29724.\">Fix</span> <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2330881837\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29724\" data-hovercard-type=\"issue\" data-hovercard-url=\"/facebook/react/issues/29724/hovercard\" href=\"https://github.com/facebook/react/issues/29724\">#29724</a>: <code>ip</code> dependency update for <a title=\"CVE-2024-29415\" data-hovercard-type=\"advisory\" data-hovercard-url=\"/advisories/GHSA-2p57-rm9w-gvfp/hovercard\" href=\"https://github.com/advisories/GHSA-2p57-rm9w-gvfp\">CVE-2024-29415</a> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2330914987\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29725\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29725/hovercard\" href=\"https://github.com/facebook/react/pull/29725\">#29725</a>)"}},{"before":"35b89f6cf12ed126f88e2b42770b61c145efbc24","after":"ea1a15c39aae5032d4d7df4395bcf4874d25e2d8","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-05T07:46:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"[Flight] Override prepareStackTrace when reading stacks (#29740)\n\nThis lets us ensure that we use the original V8 format and it lets us\nskip source mapping. Source mapping every call can be expensive since we\ndo it eagerly for server components even if an error doesn't happen.\n\nIn the case of an error being thrown we don't actually always do this in\npractice because if a try/catch before us touches it or if something in\nonError touches it (which the default console.error does), it has\nalready been initialized. So we have to be resilient to thrown errors\nhaving other formats.\n\nThese are not as perf sensitive since something actually threw but if\nyou want better perf in these cases, you can simply do something like\n`onError(error) { console.error(error.message) }` instead.\n\nThe server has to be aware whether it's looking up original or compiled\noutput. I currently use the file:// check to determine if it's referring\nto a source mapped file or compiled file in the fixture. A bundled app\ncan more easily check if it's a bundle or not.\n\nDiffTrain build for commit https://github.com/facebook/react/commit/1df34bdf626af3e4566364dcdf7f1c387d2f4252.","shortMessageHtmlLink":"[Flight] Override prepareStackTrace when reading stacks (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2331853895\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29740\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29740/hovercard\" href=\"https://github.com/facebook/react/pull/29740\">#29740</a>)"}},{"before":"d2767c96e80a6fdc35b002f1518d01d90e2a8528","after":"1df34bdf626af3e4566364dcdf7f1c387d2f4252","ref":"refs/heads/main","pushedAt":"2024-06-05T07:41:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eps1lon","name":"Sebastian Silbermann","path":"/eps1lon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12292047?s=80&v=4"},"commit":{"message":"[Flight] Override prepareStackTrace when reading stacks (#29740)\n\nThis lets us ensure that we use the original V8 format and it lets us\r\nskip source mapping. Source mapping every call can be expensive since we\r\ndo it eagerly for server components even if an error doesn't happen.\r\n\r\nIn the case of an error being thrown we don't actually always do this in\r\npractice because if a try/catch before us touches it or if something in\r\nonError touches it (which the default console.error does), it has\r\nalready been initialized. So we have to be resilient to thrown errors\r\nhaving other formats.\r\n\r\nThese are not as perf sensitive since something actually threw but if\r\nyou want better perf in these cases, you can simply do something like\r\n`onError(error) { console.error(error.message) }` instead.\r\n\r\nThe server has to be aware whether it's looking up original or compiled\r\noutput. I currently use the file:// check to determine if it's referring\r\nto a source mapped file or compiled file in the fixture. A bundled app\r\ncan more easily check if it's a bundle or not.","shortMessageHtmlLink":"[Flight] Override prepareStackTrace when reading stacks (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2331853895\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29740\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29740/hovercard\" href=\"https://github.com/facebook/react/pull/29740\">#29740</a>)"}},{"before":"170f76dfb74f6a8ffda7fad13c6e78c70a7481cc","after":"35b89f6cf12ed126f88e2b42770b61c145efbc24","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-04T22:14:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"[Flight] Encode fragments properly in DEV (#29762)\n\nNormally we take the renderClientElement path but this is an internal\nfast path.\n\nNo tests because we don't run tests with console.createTask (which is\nnot easy since we test component stacks).\n\nIdeally this would be covered by types but since the types don't\nconsider flags and DEV it doesn't really help.\n\nDiffTrain build for commit https://github.com/facebook/react/commit/d2767c96e80a6fdc35b002f1518d01d90e2a8528.","shortMessageHtmlLink":"[Flight] Encode fragments properly in DEV (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2334442360\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29762\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29762/hovercard\" href=\"https://github.com/facebook/react/pull/29762\">#29762</a>)"}},{"before":"eabb681535ab9582c0785049c5a16f8851430ff2","after":"d2767c96e80a6fdc35b002f1518d01d90e2a8528","ref":"refs/heads/main","pushedAt":"2024-06-04T22:10:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"[Flight] Encode fragments properly in DEV (#29762)\n\nNormally we take the renderClientElement path but this is an internal\r\nfast path.\r\n\r\nNo tests because we don't run tests with console.createTask (which is\r\nnot easy since we test component stacks).\r\n\r\nIdeally this would be covered by types but since the types don't\r\nconsider flags and DEV it doesn't really help.","shortMessageHtmlLink":"[Flight] Encode fragments properly in DEV (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2334442360\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29762\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29762/hovercard\" href=\"https://github.com/facebook/react/pull/29762\">#29762</a>)"}},{"before":"bdd00744ea0e574a90a3d384d7b3ed02c16b3b98","after":"170f76dfb74f6a8ffda7fad13c6e78c70a7481cc","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-04T17:12:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Add xplat test variants (#29734)\n\n## Overview\n\nWe didn't have any tests that ran in persistent mode with the xplat\nfeature flags (for either variant).\n\nAs a result, invalid test gating like in\nhttps://github.com/facebook/react/pull/29664 were not caught.\n\nThis PR adds test flavors for `ReactFeatureFlag-native-fb.js` in both\nvariants.\n\nDiffTrain build for commit https://github.com/facebook/react/commit/eabb681535ab9582c0785049c5a16f8851430ff2.","shortMessageHtmlLink":"Add xplat test variants (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2331399822\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29734\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29734/hovercard\" href=\"https://github.com/facebook/react/pull/29734\">#29734</a>)"}},{"before":"9185b9b1e4a716f90774c4c5501fe3925bc7c402","after":"eabb681535ab9582c0785049c5a16f8851430ff2","ref":"refs/heads/main","pushedAt":"2024-06-04T17:07:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rickhanlonii","name":"Ricky","path":"/rickhanlonii","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2440089?s=80&v=4"},"commit":{"message":"Add xplat test variants (#29734)\n\n## Overview\r\n\r\nWe didn't have any tests that ran in persistent mode with the xplat\r\nfeature flags (for either variant).\r\n\r\nAs a result, invalid test gating like in\r\nhttps://github.com/facebook/react/pull/29664 were not caught.\r\n\r\nThis PR adds test flavors for `ReactFeatureFlag-native-fb.js` in both\r\nvariants.","shortMessageHtmlLink":"Add xplat test variants (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2331399822\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29734\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29734/hovercard\" href=\"https://github.com/facebook/react/pull/29734\">#29734</a>)"}},{"before":"29f0ad29e6662d113561d14792f2f9e7f3cf29ee","after":"bdd00744ea0e574a90a3d384d7b3ed02c16b3b98","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-04T16:28:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Remove startTransition and useActionState from react-server condition of react (#29753)\n\n<!--\n  Thanks for submitting a pull request!\nWe appreciate you spending the time to work on these changes. Please\nprovide enough information so that others can review your pull request.\nThe three fields below are mandatory.\n\nBefore submitting a pull request, please make sure the following is\ndone:\n\n1. Fork [the repository](https://github.com/facebook/react) and create\nyour branch from `main`.\n  2. Run `yarn` in the repository root.\n3. If you've fixed a bug or added code that should be tested, add tests!\n4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch\nTestName` is helpful in development.\n5. Run `yarn test --prod` to test in the production environment. It\nsupports the same options as `yarn test`.\n6. If you need a debugger, run `yarn test --debug --watch TestName`,\nopen `chrome://inspect`, and press \"Inspect\".\n7. Format your code with\n[prettier](https://github.com/prettier/prettier) (`yarn prettier`).\n8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only\ncheck changed files.\n  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).\n  10. If you haven't already, complete the CLA.\n\nLearn more about contributing:\nhttps://reactjs.org/docs/how-to-contribute.html\n-->\n\n## Summary\n\nRemove `startTransition` and `useActionState` from `react-server`\ncondition of react, as they should only stay in client bundle.\nThis will reduce the server bundle of react itself.\n\nFound this while tracing where the `process.emit` was called.\n\n<!--\nExplain the **motivation** for making this change. What existing problem\ndoes the pull request solve?\n-->\n\n## How did you test this change?\n\n<!--\nDemonstrate the code is solid. Example: The exact commands you ran and\ntheir output, screenshots / videos if the pull request changes the user\ninterface.\nHow exactly did you verify that your PR solves the issue you wanted to\nsolve?\n  If you leave this empty, your PR will very likely be closed.\n-->\n\nDiffTrain build for commit https://github.com/facebook/react/commit/9185b9b1e4a716f90774c4c5501fe3925bc7c402.","shortMessageHtmlLink":"Remove startTransition and useActionState from react-server condition…"}},{"before":"a26e90c29cfa841d3e2bc08876c5929d5680fb6d","after":"9185b9b1e4a716f90774c4c5501fe3925bc7c402","ref":"refs/heads/main","pushedAt":"2024-06-04T16:23:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sebmarkbage","name":"Sebastian Markbåge","path":"/sebmarkbage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/63648?s=80&v=4"},"commit":{"message":"Remove startTransition and useActionState from react-server condition of react (#29753)\n\n<!--\r\n  Thanks for submitting a pull request!\r\nWe appreciate you spending the time to work on these changes. Please\r\nprovide enough information so that others can review your pull request.\r\nThe three fields below are mandatory.\r\n\r\nBefore submitting a pull request, please make sure the following is\r\ndone:\r\n\r\n1. Fork [the repository](https://github.com/facebook/react) and create\r\nyour branch from `main`.\r\n  2. Run `yarn` in the repository root.\r\n3. If you've fixed a bug or added code that should be tested, add tests!\r\n4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch\r\nTestName` is helpful in development.\r\n5. Run `yarn test --prod` to test in the production environment. It\r\nsupports the same options as `yarn test`.\r\n6. If you need a debugger, run `yarn test --debug --watch TestName`,\r\nopen `chrome://inspect`, and press \"Inspect\".\r\n7. Format your code with\r\n[prettier](https://github.com/prettier/prettier) (`yarn prettier`).\r\n8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only\r\ncheck changed files.\r\n  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).\r\n  10. If you haven't already, complete the CLA.\r\n\r\nLearn more about contributing:\r\nhttps://reactjs.org/docs/how-to-contribute.html\r\n-->\r\n\r\n## Summary\r\n\r\nRemove `startTransition` and `useActionState` from `react-server`\r\ncondition of react, as they should only stay in client bundle.\r\nThis will reduce the server bundle of react itself. \r\n\r\nFound this while tracing where the `process.emit` was called.\r\n\r\n<!--\r\nExplain the **motivation** for making this change. What existing problem\r\ndoes the pull request solve?\r\n-->\r\n\r\n## How did you test this change?\r\n\r\n<!--\r\nDemonstrate the code is solid. Example: The exact commands you ran and\r\ntheir output, screenshots / videos if the pull request changes the user\r\ninterface.\r\nHow exactly did you verify that your PR solves the issue you wanted to\r\nsolve?\r\n  If you leave this empty, your PR will very likely be closed.\r\n-->","shortMessageHtmlLink":"Remove startTransition and useActionState from react-server condition…"}},{"before":"2003e2482cec0cc8d185f67e87b5b4136ca28319","after":"29f0ad29e6662d113561d14792f2f9e7f3cf29ee","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-04T15:22:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"www: set enableRefAsProp to true (#29756)\n\nwww: set enableRefAsProp to true\n\nDiffTrain build for commit https://github.com/facebook/react/commit/a26e90c29cfa841d3e2bc08876c5929d5680fb6d.","shortMessageHtmlLink":"www: set enableRefAsProp to true (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2333751235\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29756\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29756/hovercard\" href=\"https://github.com/facebook/react/pull/29756\">#29756</a>)"}},{"before":"dae837bc64d1e472f78f56e02fc07e62714ea394","after":"d3308e2254696f6a62b78950d08e9e21b903b631","ref":"refs/heads/builds/facebook-www","pushedAt":"2024-06-04T15:22:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"www: set enableRefAsProp to true (#29756)\n\nwww: set enableRefAsProp to true\n\nDiffTrain build for [a26e90c29cfa841d3e2bc08876c5929d5680fb6d](https://github.com/facebook/react/commit/a26e90c29cfa841d3e2bc08876c5929d5680fb6d)","shortMessageHtmlLink":"www: set enableRefAsProp to true (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2333751235\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29756\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29756/hovercard\" href=\"https://github.com/facebook/react/pull/29756\">#29756</a>)"}},{"before":"408258268edb5acdfdbf77bc6e0b0dc6396c0e6f","after":"a26e90c29cfa841d3e2bc08876c5929d5680fb6d","ref":"refs/heads/main","pushedAt":"2024-06-04T15:17:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kassens","name":"Jan Kassens","path":"/kassens","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11849?s=80&v=4"},"commit":{"message":"www: set enableRefAsProp to true (#29756)\n\nwww: set enableRefAsProp to true","shortMessageHtmlLink":"www: set enableRefAsProp to true (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2333751235\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/react/issues/29756\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/react/pull/29756/hovercard\" href=\"https://github.com/facebook/react/pull/29756\">#29756</a>)"}},{"before":null,"after":"408258268edb5acdfdbf77bc6e0b0dc6396c0e6f","ref":"refs/heads/jbonta_hover","pushedAt":"2024-06-04T03:10:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jbonta","name":"Jason Bonta","path":"/jbonta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/973058?s=80&v=4"},"commit":{"message":"fix<compiler>: only call readTestFilter if the filter option is enabled (#29720)\n\nFollowing the instructions in the compiler/docs/DEVELOPMENT_GUIDE.md, we are stuck on the command `yarn snap --watch` because it calls readTestFilter even though the filter option is not enabled.","shortMessageHtmlLink":"fix&lt;compiler&gt;: only call readTestFilter if the filter option is enabl…"}},{"before":"ce4eb8169e70ee1248749ad587cd8efe4e04ee92","after":"2003e2482cec0cc8d185f67e87b5b4136ca28319","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-03T23:15:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"fix<compiler>: only call readTestFilter if the filter option is enabled (#29720)\n\nFollowing the instructions in the compiler/docs/DEVELOPMENT_GUIDE.md, we are stuck on the command `yarn snap --watch` because it calls readTestFilter even though the filter option is not enabled.\n\nDiffTrain build for commit https://github.com/facebook/react/commit/408258268edb5acdfdbf77bc6e0b0dc6396c0e6f.","shortMessageHtmlLink":"fix&lt;compiler&gt;: only call readTestFilter if the filter option is enabl…"}},{"before":"8b677b1e6ea6cd0f7a5c3b32164c127f1fceb360","after":"408258268edb5acdfdbf77bc6e0b0dc6396c0e6f","ref":"refs/heads/main","pushedAt":"2024-06-03T23:09:58.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"josephsavona","name":"Joseph Savona","path":"/josephsavona","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6425824?s=80&v=4"},"commit":{"message":"fix<compiler>: only call readTestFilter if the filter option is enabled (#29720)\n\nFollowing the instructions in the compiler/docs/DEVELOPMENT_GUIDE.md, we are stuck on the command `yarn snap --watch` because it calls readTestFilter even though the filter option is not enabled.","shortMessageHtmlLink":"fix&lt;compiler&gt;: only call readTestFilter if the filter option is enabl…"}},{"before":"ff6541780915aedfa25fb16d56d49997533efa27","after":"ce4eb8169e70ee1248749ad587cd8efe4e04ee92","ref":"refs/heads/builds/facebook-fbsource","pushedAt":"2024-06-03T22:37:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"compiler: Allow opting out of installed library check\n\nghstack-source-id: eedd024d36f66a68abe43ba0f679e2d462b77505\nPull Request resolved: https://github.com/facebook/react/pull/29742\n\nDiffTrain build for commit https://github.com/facebook/react/commit/8b677b1e6ea6cd0f7a5c3b32164c127f1fceb360.","shortMessageHtmlLink":"compiler: Allow opting out of installed library check"}},{"before":"06ed4ef0d53dbef9789e1685b8d1240e107106de","after":null,"ref":"refs/heads/gh/josephsavona/21/orig","pushedAt":"2024-06-03T22:31:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"josephsavona","name":"Joseph Savona","path":"/josephsavona","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6425824?s=80&v=4"}},{"before":"8fcda799a6143d0487163a529a871c90a1ed33eb","after":null,"ref":"refs/heads/gh/josephsavona/21/head","pushedAt":"2024-06-03T22:31:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"josephsavona","name":"Joseph Savona","path":"/josephsavona","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6425824?s=80&v=4"}},{"before":"8fcda799a6143d0487163a529a871c90a1ed33eb","after":null,"ref":"refs/heads/gh/josephsavona/21/base","pushedAt":"2024-06-03T22:31:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"josephsavona","name":"Joseph Savona","path":"/josephsavona","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6425824?s=80&v=4"}},{"before":"8c3697a849b7e9ceeb47642ba61c270b7e6dd176","after":"8b677b1e6ea6cd0f7a5c3b32164c127f1fceb360","ref":"refs/heads/main","pushedAt":"2024-06-03T22:31:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"josephsavona","name":"Joseph Savona","path":"/josephsavona","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6425824?s=80&v=4"},"commit":{"message":"compiler: Allow opting out of installed library check\n\nghstack-source-id: eedd024d36f66a68abe43ba0f679e2d462b77505\nPull Request resolved: https://github.com/facebook/react/pull/29742","shortMessageHtmlLink":"compiler: Allow opting out of installed library check"}},{"before":"8c3697a849b7e9ceeb47642ba61c270b7e6dd176","after":"8fcda799a6143d0487163a529a871c90a1ed33eb","ref":"refs/heads/gh/josephsavona/21/base","pushedAt":"2024-06-03T22:30:58.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"josephsavona","name":"Joseph Savona","path":"/josephsavona","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6425824?s=80&v=4"},"commit":{"message":"Update on \"compiler: Allow opting out of installed library check\"\n\n\n\n\n[ghstack-poisoned]","shortMessageHtmlLink":"Update on \"compiler: Allow opting out of installed library check\""}},{"before":"696707c45408383faa8f0f990bc3991eda6144da","after":"471d04bb855a3f46686281885c90b219acfb5231","ref":"refs/heads/gh/josephsavona/19/orig","pushedAt":"2024-06-03T22:30:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"josephsavona","name":"Joseph Savona","path":"/josephsavona","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6425824?s=80&v=4"},"commit":{"message":"compiler: allow reordering of loadlocal after last assignment\n\nExtends the instruction reordering from the previous PR to allow reordering LoadLocal, but only after the last assignment of the loaded variable.\n\nThus if we have:\n\n```\nt0 = StoreLocal const x = ...\nt1 = LoadLocal x\nt2 = foo\nt3 = bar t1 # t1 used here\n```\n\nWe know that x isn't assigned after the first instruction, and can safely reorder the loadlocal to where it's first used:\n\n```\nt0 = StoreLocal const x = ...\nt2 = foo\nt1 = LoadLocal x\nt3 = bar t1\n```\n\nNote that this assumes each LoadLocal temporary is used exactly once, which we already guarantee in BuildHIR.\n\nghstack-source-id: 8781cb6763f87a593b92583df6a3fbc368e078e7\nPull Request resolved: https://github.com/facebook/react/pull/29668","shortMessageHtmlLink":"compiler: allow reordering of loadlocal after last assignment"}},{"before":"d620dfe12b27e97ad43379d9646850e06aee7e33","after":"a9261ad504b50d549f9e6c21623f075a5c90a02c","ref":"refs/heads/gh/josephsavona/19/head","pushedAt":"2024-06-03T22:30:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"josephsavona","name":"Joseph Savona","path":"/josephsavona","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6425824?s=80&v=4"},"commit":{"message":"Update on \"compiler: allow reordering of loadlocal after last assignment\"\n\n\nExtends the instruction reordering from the previous PR to allow reordering LoadLocal, but only after the last assignment of the loaded variable.\n\nThus if we have:\n\n```\nt0 = StoreLocal const x = ...\nt1 = LoadLocal x\nt2 = foo\nt3 = bar t1 # t1 used here\n```\n\nWe know that x isn't assigned after the first instruction, and can safely reorder the loadlocal to where it's first used:\n\n```\nt0 = StoreLocal const x = ...\nt2 = foo\nt1 = LoadLocal x\nt3 = bar t1\n```\n\nNote that this assumes each LoadLocal temporary is used exactly once, which we already guarantee in BuildHIR.\n\n[ghstack-poisoned]","shortMessageHtmlLink":"Update on \"compiler: allow reordering of loadlocal after last assignm…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEXaZ_AQA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/react"}