Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Multiple test failures JDK23 on main #108776

Closed
cbuescher opened this issue May 17, 2024 · 2 comments · Fixed by #108822
Closed

[CI] Multiple test failures JDK23 on main #108776

cbuescher opened this issue May 17, 2024 · 2 comments · Fixed by #108822
Labels
:Delivery/Build Build or test infrastructure needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Delivery Meta label for Delivery team >test-failure Triaged test failures from CI

Comments

@cbuescher
Copy link
Member

Multiple test failures due to "Unsupported class file major version 67".

e.g. https://gradle-enterprise.elastic.co/s/3vr5hou5vgyzc/tests/task/:libs:elasticsearch-plugin-scanner:test/details/org.elasticsearch.plugin.scanner.NamedComponentScannerTests/testNamedComponentsAreFoundWhenSingleJarProvided?top-execution=1

./gradlew ':libs:elasticsearch-plugin-scanner:test' --tests "org.elasticsearch.plugin.scanner.NamedComponentScannerTests.testNamedComponentsAreFoundWhenSingleJarProvided" -Dtests.seed=8BC38CBC63E90492 -Dtests.locale=es -Dtests.timezone=America/Indiana/Winamac -Druntime.java=23

But there are plenty of others popping up atm, e.g.

org.elasticsearch.plugin.scanner.NamedComponentScannerTests
testNamedComponentsAreFoundWhenSingleJarProvided
testNamedComponentsCanExtednCommonSuperClass
org.elasticsearch.plugin.scanner.ClassReadersTests
testMultipleJarsInADir
testStreamOfJarsAndIndividualClasses
testTwoClassesInAStreamFromJar

Reproduces locally for me with Open JDK "23.ea.22-open"
@cbuescher cbuescher added :Delivery/Build Build or test infrastructure >test-failure Triaged test failures from CI labels May 17, 2024
@elasticsearchmachine elasticsearchmachine added Team:Delivery Meta label for Delivery team needs:risk Requires assignment of a risk label (low, medium, blocker) labels May 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@cbuescher
Copy link
Member Author

Errors look something like this:

org.elasticsearch.plugin.scanner.NamedComponentScannerTests > testNamedComponentsAreFoundWhenSingleJarProvided FAILED
    java.lang.IllegalArgumentException: Unsupported class file major version 67
        at __randomizedtesting.SeedInfo.seed([8BC38CBC63E90492:B04F9487A9BDCBDE]:0)
        at org.objectweb.asm.ClassReader.<init>(ClassReader.java:200)
        at org.objectweb.asm.ClassReader.<init>(ClassReader.java:180)
        at org.objectweb.asm.ClassReader.<init>(ClassReader.java:166)
        at org.elasticsearch.plugin.scanner.ClassReaders.lambda$classesInPath$5(ClassReaders.java:97)

@rjernst rjernst mentioned this issue May 20, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue May 20, 2024
@rjernst
Update ASM to 9.7 for plugin scanner (#108822)
9e6fe11 
This commit updates the ASM library in order to support class files
written with Java 23.

closes #108776
jedrazb pushed a commit to jedrazb/elasticsearch that referenced this issue May 21, 2024
@rjernst @jedrazb
Update ASM to 9.7 for plugin scanner (elastic#108822)
3bba679 
This commit updates the ASM library in order to support class files
written with Java 23.

closes elastic#108776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Delivery/Build Build or test infrastructure needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Delivery Meta label for Delivery team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ASM to 9.7 for plugin scanner rjernst/elasticsearch
2 participants
@cbuescher @elasticsearchmachine