Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: $dynamic queries drops the initial 'where' part of the clause #2321

Open
gerhardcit opened this issue May 15, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@gerhardcit
Copy link

What version of drizzle-orm are you using?

0.30.10

What version of drizzle-kit are you using?

0.21.1

Describe the Bug

Dynamic query building does not work as indicated here: https://orm.drizzle.team/docs/dynamic-query-building

AI answers suggested this code to created a dynamic query:

To construct an optional where clause in Drizzle with optional "and" fields, including a condition only if you have specific search criteria for that field, you can utilize the dynamic query building feature of Drizzle. This feature allows you to build queries dynamically, adjusting the conditions based on the input data you have.

async function queryWithOptionalConditions(tenant: string, areaMatch?: string, suburbMatch?: string) {
    let query = db.select().from(yourTable).where(eq(yourTable.tenant, tenant));

    if (areaMatch || suburbMatch) {
        query = query.$dynamic().where(or(
            areaMatch ? eq(yourTable.area, areaMatch) : undefined,
            suburbMatch ? eq(yourTable.suburb, suburbMatch) : undefined
        ));
    }
    console.log("sql", query.toSQL());
    return await query;
}

Run it as follows:

const res = await queryWithOptionalConditions("tenant1", "area53", "")

The log printed out is this:

 select "id", "tenant", "area", "suburb"  from "owners" where "owners"."name" = ?',
  params: [ 'area53' ]

Expected behavior

the expected code should be

 select "id", "tenant", "area", "suburb"  from "owners"  where "owners"."tenant" = ? 
AND  "owners"."name" = ?',
 params: [ 'tenant1", 'area53' ]

note that the "where tenant = 'xxx" has gone missing.

Environment & setup

Testing this in sveltelkit project running on cloudflare.

Referring to this page: https://orm.drizzle.team/docs/dynamic-query-building
The documentation starts with this problem:

const query = db
  .select()
  .from(users)
  .where(eq(users.id, 1))
  .where(eq(users.name, 'John')); // ❌ Type error - where() can only be invoked once

but never really address this problem of adding optional where based on the input matching fields.

It goes into adding joins, and limits etc, where it should also address the optional where fields which is classic in searching sql dbs.

@gerhardcit gerhardcit added the bug Something isn't working label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant