Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user statistics: Hide approvals if 0 #5668

Open
ErikHumphrey opened this issue Apr 4, 2024 · 0 comments
Open

user statistics: Hide approvals if 0 #5668

ErikHumphrey opened this issue Apr 4, 2024 · 0 comments
Labels
Alteration Changes to an existing feature.

Comments

@ErikHumphrey
Copy link
Contributor

ErikHumphrey commented Apr 4, 2024

image

If a user both has made no approvals, user profiles shouldn't show "Approvals: 0" in the stats table for the user or other users.

Almost all users are never approvers, so there's no point in showing this stat, but it should show if they made approvals when they were an approver in the past.

Optionally, it could also still show if the user is an approver, but "approver with 0 approvals" is a rare case, so maybe a second condition isn't worth implementing.

@nonamethanks nonamethanks added the Alteration Changes to an existing feature. label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Alteration Changes to an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants