Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毟 All cmdlets with module/model parameters should support ValueFromPipelineByPropertyName and ValueFromPipeline #729

Open
FH-Inway opened this issue Apr 30, 2023 · 2 comments

Comments

@FH-Inway
Copy link
Member

There are multiple cmdlets that have a (often mandatory) Module and/or Model parameter. Some of those cmdlets decorate those parameters with the ValueFromPipelineByPropertyName and/or ValueFromPipeline attributes. This makes the cmdlets easy to use in combination with other cmdlets that return a list of modules, such as Get-D365Module.

To provide a consistent user experience, it would be nice if all cmdlets support the ValueFromPipeline* options.

I.e. one can do
Get-D365Module -Name "MyPrefix*" | Invoke-D365ModuleFullCompile
but not
Get-D365Module -Name "MyPrefix*" | Invoke-D365ProcessModule -ExecuteCompile

@FH-Inway FH-Inway changed the title All cmdlets with module/model parameters should support ValueFromPipelineByPropertyName and ValueFromPipeline 馃毟 All cmdlets with module/model parameters should support ValueFromPipelineByPropertyName and ValueFromPipeline Apr 30, 2023
@Splaxi
Copy link
Collaborator

Splaxi commented Apr 30, 2023

I'm all in favor, but don't have an overview of how much work this will require.

Happy to split the workload between us, so you don't have to do all the heavy lifting yourself...

@FH-Inway
Copy link
Member Author

I will compile a list of cmdlets that we should look at. Searching for "[string] $Module" in the functions seems to be a good starting point. Finds 13 files and about half of them already have pipeline support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants