@jhooper04 thanks for creating this issue! 🙏🏼 Let me double check with the team we want this type of behavior.

I checked with the team and we agreed this is something we should have.

hi @stnguyen90 I would be really happy to fix this issue . If possible can you please assign this to me ?

@lucifer-Hell assigned! Thanks for your interest! 🙏

Hi team just a quick update . It seems that whenever the create event is called for a member to be created the project id which is passed to the register function is not console. Hence it throws the error. Below is the line code which checks the project id : -
if ($limit !== 0 && $project->getId() !== 'console') { // check users limit, console invites are always allowed.
I am trying to find out what would be the possible reason for the same.

@lucifer-Hell, yes, that is correct. The project ID would be the project ID in which the team membership is being created in.

FYI, you can add a permalink on GitHub and it will render the code. For example:

Hi @stnguyen90 , i have proposal to fix this bug . Rather then relying onproject->getId() we can you use the header x-sdk-platform which comes along the request to check whether the incoming request is from console or not. Following is the change that i am thinking of . Please let me know if this seems okay

$platformType= $request->header('x-sdk-platform', 'default'); if ($limit !== 0 && $platformType !== 'console') { // check users limit, console invites are allways allowed. $total = $dbForProject->count('users', [], APP_LIMIT_USERS);

Also thanks! for the permalink suggestion I will use the same in my prs from know onwards .

we can you use the header x-sdk-platform which comes along the request

@lucifer-Hell, it's typically not a good idea to rely on client-supplied data like that since the client can send any value it wants.

This is the current code

Can't we simply do something like this?

if (empty($invitee)) { // Create new user if no user with same email found
  $limit = $project->getAttribute('auths', [])['limit'] ?? 0;

  $isPrivilegedUser ? $limit = 0 : null; // <----- I added this line

  if ($limit !== 0 && $project->getId() !== 'console') { // check users limit, console invites are allways allowed.
      $total = $dbForProject->count('users', [], APP_LIMIT_USERS);
      // rest of the code

@safwanyp, I'd probably leave the limit number rather than modifying it based on $isPrivilegedUser for clarity.

@stnguyen90 Noted, and I did this instead:

if (empty($invitee)) { // Create new user if no user with same email found
  $limit = $project->getAttribute('auths', [])['limit'] ?? 0;

  $shouldCheckLimit = !$isPrivilegedUser && $limit !== 0 && $project->getId() !== 'console';

  if ($shouldCheckLimit) { // check users limit, console invites are allways allowed.
      $total = $dbForProject->count('users', [], APP_LIMIT_USERS);

      if ($total >= $limit) {
          throw new Exception(Exception::USER_COUNT_EXCEEDED, 'Project registration is restricted. Contact your administrator for more information.');
      }
  }
  // rest of the code

Instead of modifying $limit directly, I created $shouldCheckLimit that checks whether the limit should be taken into account or not.

@lucifer-Hell, how's your progress on this?

As the previous assignee is not working on it, can you assign it to me

Just realised @safwanyp had already got the solution

can i work on this?

Unassigning due to inactivity.

@ketanbaitule, @nick2432, are y'all still interested in working on this?

Hi @stnguyen90, I am interested to work on this issue.

Unassigning due to inactivity.

@ketanbaitule, @nick2432, are y'all still interested in working on this?

@ketanbaitule, assigned! Thanks for your interest! 🙏