Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify property name security judgement #14208

Merged
merged 1 commit into from
May 21, 2024

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented May 18, 2024

What is the purpose of the change

fixed #14207

Brief changelog

  1. split property name to fragments by dot char.
  2. deny the property name if securityKey list contains the last fragment of the property name based on kebab-case comparison.
    refer to URLParam#removeParameters using by AbstractConfiguratorListener#genConfiguratorsFromRawRule.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@zrlw zrlw force-pushed the 3.2-feature-fixedSecurityKeyComparion branch 3 times, most recently from 1cd5b0a to a8f0128 Compare May 20, 2024 08:42
@zrlw zrlw force-pushed the 3.2-feature-fixedSecurityKeyComparion branch from a8f0128 to afa2543 Compare May 20, 2024 09:12
Copy link

sonarcloud bot commented May 20, 2024

@AlbumenJ AlbumenJ merged commit e21244a into apache:3.2 May 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] setting dubbo.application.metadata-type at config center does not take effect
2 participants